Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Mar 2009 17:36:38 +0300
From:      Dmitry Marakasov <amdmi3@amdmi3.ru>
To:        Oliver Lehmann <lehmann@ans-netz.de>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/audio/openal Makefile
Message-ID:  <20090316143638.GA26242@hades.panopticon>
In-Reply-To: <20090316064227.ef50f937.lehmann@ans-netz.de>
References:  <200903160054.n2G0sdCq010298@repoman.freebsd.org> <20090316064227.ef50f937.lehmann@ans-netz.de>

next in thread | previous in thread | raw e-mail | index | archive | help
* Oliver Lehmann (lehmann@ans-netz.de) wrote:

> Will this also fix the following PR? (scroll below for the openal patch)

Seems so. I guess the fix in that PR is even better, as optimized
assembly code is used.

I think we can merge both fixes, something like that:

.if ${ARCH} == "i386"
OPTIONS+=	X86_ASM	"Enable x86 assembly code" on
.endif

...

.if ${ARCH} == "i386" && !defined(WITHOUT_X86_ASM)
BUILD_DEPENDS+=	nasm:${LOCALBASE}/devel/nasm
.endif

...

post-patch:
.if ${ARCH} != "i386" || defined(WITHOUT_X86_ASM)
	@${REINPLACE_CMD} -e '/^NASM=/ s|=.*|=no|' ${WRKSRC}/configure
.endif

and patches from ports/129362.

What do you think?

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090316143638.GA26242>