Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Jan 2007 14:25:09 +0200
From:      Kostik Belousov <kostikbel@gmail.com>
To:        "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/fs/deadfs dead_vnops.c src/sys/kern vfs_lookup.c
Message-ID:  <20070122122509.GB71333@deviant.kiev.zoral.com.ua>
In-Reply-To: <20070122115230.J82671@maildrop.int.zabbadoz.net>
References:  <200701221125.l0MBPMS4041567@repoman.freebsd.org> <20070122115230.J82671@maildrop.int.zabbadoz.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--neYutvxvOLaeuPCA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 22, 2007 at 11:53:50AM +0000, Bjoern A. Zeeb wrote:
> On Mon, 22 Jan 2007, Konstantin Belousov wrote:
>=20
> >kib         2007-01-22 11:25:22 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> >   sys/fs/deadfs        dead_vnops.c
> >   sys/kern             vfs_lookup.c
> > Log:
> > Below is slightly edited description of the LOR by Tor Egge:
> >
> > --------------------------
> > [Deadlock] is caused by a lock order reversal in vfs_lookup(), where
> > [some] process is trying to lock a directory vnode, that is the parent
> > directory of covered vnode) while holding an exclusive vnode lock on
> > covering vnode.
> >....
> > To fix the LOR, ups@ noted that when crossing the mount point, ni_dvp
> > is actually not used by the callers of namei. Thus, placeholder deadfs
> > vnode vp_crossmp is introduced that is filled into ni_dvp.
>=20
> which of the LOR #s on "The LOR page" can be marked "patched" with
> this commit?
>=20
> http://sources.zabbadoz.net/freebsd/lor.html

None, your page lists only LORs that are detectable by WITNESS. This one is
between lockmgr lock and vfs_busy(), both of them are invisible to WITNESS.

--neYutvxvOLaeuPCA
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFFtK0lC3+MBN1Mb4gRAv6HAJ0cN41/ijkzx+k+izWdJQlUu9JcOgCcDxU2
AUNqBy9O8NEBorGBB1HqspA=
=3jUK
-----END PGP SIGNATURE-----

--neYutvxvOLaeuPCA--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070122122509.GB71333>