Date: Mon, 26 Nov 2012 20:12:14 +0100 From: Erwin Lansing <erwin@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, Guido Falsi <madpilot@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r307782 - head/audio/asunder Message-ID: <20121126191213.GB4474@droso.net> In-Reply-To: <CAF6rxg=qHkUEPt9f7KG=jdiS0rgR80byM83GDjnYExa74u=dzA@mail.gmail.com> References: <201211261259.qAQCxdXD089022@svn.freebsd.org> <20121126135609.GC62928@FreeBSD.org> <50B39163.2040309@FreeBSD.org> <20121126161113.GA72036@FreeBSD.org> <CAF6rxg=qHkUEPt9f7KG=jdiS0rgR80byM83GDjnYExa74u=dzA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 26, 2012 at 11:57:37AM -0500, Eitan Adler wrote:
> On 26 November 2012 11:11, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > On Mon, Nov 26, 2012 at 04:57:23PM +0100, Guido Falsi wrote:
> >> On 11/26/12 14:56, Alexey Dokuchaev wrote:
> >> >We have standard knob for this one (APE_DESC).
> >> >
> >> >> PORTDOCS= AUTHORS COPYING ChangeLog INSTALL NEWS README TODO
> >> >
> >> >Normally we do not install COPYING as part of the docs, LICENSE should be
> >> >set instead. If software expects to find this file (e.g. for displaying in
> >> >the about dialog), it should be redirected to share/licenses/${PKGNAME}
> >> >instead (see `graphics/luminance' port for an example).
> >>
> >> Thanks for these, I'll fix them and commit after maintainer approval.
> >
> > Technically speaking, you don't have to have maintainer's approval for these
> > things, as they don't affect functionality, just make the port more adhering
> > to our standards (and common sense).
>
> It is good to ping the maintainer though unless there is specific reason not to.
> - Since they signed up to maintain the port its nice not to change
> things without asking
> - It teaches the maintainers about our standards :)
>
Actually, if you strictly follow our rules, the maintainer has the final
say and you have to ask beforehand, with the usual timeouts. For
trivial changes, e.g., updating CONFLICTS for a slave port, you may not
want to wait for that and commit right away, but the least you can do is
to send a mail afterwards to the maintainer as a courtesy so they don't
have to find out by having conflicts in the their local repository if
their working on another update or similar.
Being polite really doesn't cost much.
Erwin
--
Erwin Lansing http://droso.dk
erwin@FreeBSD.org http:// www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121126191213.GB4474>