Date: Sat, 23 Feb 2013 18:30:01 GMT From: nemysis <nemysis@gmx.ch> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/174015: [PATCH] finance/venice: update to 0.751beta, take maintainership, added desktop entry, icons, license Message-ID: <201302231830.r1NIU1gd064187@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/174015; it has been noted by GNATS.
From: nemysis <nemysis@gmx.ch>
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: ports/174015: [PATCH] finance/venice: update to 0.751beta, take
maintainership, added desktop entry, icons, license
Date: Sat, 23 Feb 2013 19:20:27 +0100
--MP_/a=_9TzkKIsQoeWPTFf82ITz
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Changed
DESKTOP_ENTRIES="Venice" "${COMMENT}" \
"${PREFIX}/share/pixmaps/${PORTNAME}.png" \
"${PORTNAME}" "Office;Finance;" false
--MP_/a=_9TzkKIsQoeWPTFf82ITz
Content-Type: text/x-patch
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment; filename=venice.diff
=3D=3D=3D> Generating patch
=3D=3D=3D> Viewing diff with more
diff -ruN --exclude=3DCVS /usr/ports/finance/venice/Makefile ./Makefile
--- /usr/ports/finance/venice/Makefile 2013-01-14 17:55:05.000000000 +0100
+++ ./Makefile 2013-02-23 19:13:35.000000000 +0100
@@ -2,51 +2,63 @@
# $FreeBSD: head/finance/venice/Makefile 308604 2012-12-10 13:18:28Z bapt $
=20
PORTNAME=3D venice
-DISTVERSION=3D 0.71beta
+DISTVERSION=3D 0.751beta
CATEGORIES=3D finance java
-MASTER_SITES=3D SF/mov/${PORTNAME}/0.71%20beta
-DISTNAME=3D ${PORTNAME}-${DISTVERSION}
+MASTER_SITES=3D SF/mov/${PORTNAME}/0.751%20beta/ \
+ SF/nemysisfreebsdp/:icons
+DISTFILES=3D ${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX} \
+ ${PORTNAME}_icons${EXTRACT_SUFX}:icons
+DIST_SUBDIR=3D java
=20
-MAINTAINER=3D ports@FreeBSD.org
+MAINTAINER=3D nemysis@gmx.ch
COMMENT=3D Merchant Of Venice, a stock market trading program
=20
-NO_BUILD=3D yes
+LICENSE=3D GPLv2
+
USE_JAVA=3D yes
-JAVA_RUN=3D yes
JAVA_VERSION=3D 1.6+
+NO_BUILD=3D yes
=20
-JARFILE=3D ${PORTNAME}.jar
+PORTDOCS=3D *
=20
-PLIST_FILES=3D bin/venice \
- %%JAVAJARDIR%%/${JARFILE}
+DOCSRCDIR1=3D ${WRKSRC}
+DOC_FILES1=3D changelog.txt readme.txt
=20
-# docs
-DOC_FILES=3D doc/manual.txt \
- doc/manual.html \
- changelog.txt \
- readme.txt
+DOCSRCDIR2=3D ${WRKSRC}/doc
+DOCSDIR2=3D ${DOCSDIR}/doc
+DOC_FILES2=3D manual.html manual.txt
=20
-.ifndef(NOPORTDOCS)
-PORTDOCS=3D *
-.endif
+DATADIR=3D ${JAVASHAREDIR}/${PORTNAME}
+
+SUB_FILES=3D ${PORTNAME}
=20
-.include <bsd.port.pre.mk>
+INSTALLS_ICONS=3D yes
+ICON_SIZES=3D 32x32 48x48 64x64 72x72 96x96 128x128
=20
-post-patch:
- ${REINPLACE_CMD} -e s,venice.jar,${JAVAJARDIR}/${JARFILE}, ${WRKSRC}/veni=
ce
+DESKTOP_ENTRIES=3D"Venice" "${COMMENT}" \
+ "${PREFIX}/share/pixmaps/${PORTNAME}.png" \
+ "${PORTNAME}" "Office;Finance;" false
+
+.include <bsd.port.options.mk>
=20
do-install:
-# docs
-.ifndef(NOPORTDOCS)
- @${MKDIR} ${DOCSDIR}
-.for doc in ${DOC_FILES}
- @${INSTALL_DATA} ${WRKSRC}/${doc} ${DOCSDIR}
+ ${INSTALL_SCRIPT} ${WRKDIR}/${PORTNAME} ${PREFIX}/bin/
+ ${MKDIR} ${DATADIR}
+ ${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.jar ${DATADIR}
+
+post-install:
+.for s in ${ICON_SIZES}
+ ${MKDIR} ${PREFIX}/share/icons/hicolor/${s}/apps
+ ${INSTALL_DATA} ${WRKDIR}/${PORTNAME}_${s}.png \
+ ${PREFIX}/share/icons/hicolor/${s}/apps/${PORTNAME}.png
.endfor
+ ${LN} -sf ${PREFIX}/share/icons/hicolor/48x48/apps/${PORTNAME}.png ${PREF=
IX}/share/pixmaps/
+
+.if ${PORT_OPTIONS:MDOCS}
+ ${MKDIR} ${DOCSDIR}
+ ${INSTALL_DATA} ${DOC_FILES1:S|^|${DOCSRCDIR1}/|} ${DOCSDIR}
+ ${MKDIR} ${DOCSDIR2}
+ ${INSTALL_DATA} ${DOC_FILES2:S|^|${DOCSRCDIR2}/|} ${DOCSDIR2}
.endif
-# wrapper
- @${INSTALL_SCRIPT} ${WRKSRC}/venice ${PREFIX}/bin/
-# jar
- @${MKDIR} ${JAVAJARDIR}
- @${INSTALL_DATA} ${WRKSRC}/${JARFILE} ${JAVAJARDIR}/
=20
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
diff -ruN --exclude=3DCVS /usr/ports/finance/venice/distinfo ./distinfo
--- /usr/ports/finance/venice/distinfo 2013-01-14 17:55:05.000000000 +0100
+++ ./distinfo 2013-02-23 19:06:19.000000000 +0100
@@ -1,2 +1,4 @@
-SHA256 (venice-0.71beta.tar.gz) =3D fd5e1dfc069d194b27c9566c3fd3a627a4f839=
589390b7426ad5255341d40ca5
-SIZE (venice-0.71beta.tar.gz) =3D 3553122
+SHA256 (java/venice-0.751beta.tar.gz) =3D 47005ab8dd013f24828f969f086a7249=
876f50c10445c4229431f721a26379d0
+SIZE (java/venice-0.751beta.tar.gz) =3D 4187889
+SHA256 (java/venice_icons.tar.gz) =3D 88d377528717a6a1a98a705f3e46fd0f818d=
d5f3aa3ad25122361127ee9b9858
+SIZE (java/venice_icons.tar.gz) =3D 92672
diff -ruN --exclude=3DCVS /usr/ports/finance/venice/files/venice.in ./files=
/venice.in
--- /usr/ports/finance/venice/files/venice.in 1970-01-01 01:00:00.000000000=
+0100
+++ ./files/venice.in 2012-11-30 15:37:02.000000000 +0100
@@ -0,0 +1,9 @@
+#!/bin/sh
+#
+# $FreeBSD$
+#
+
+export JAVA_VERSION=3D"%%JAVA_VERSION%%"
+
+cd "%%DATADIR%%" && exec "%%LOCALBASE%%/bin/java" \
+-Djava.ext.dirs=3D"%%DATADIR%%" -jar "%%DATADIR%%/venice.jar" "${@}"
diff -ruN --exclude=3DCVS /usr/ports/finance/venice/pkg-descr ./pkg-descr
--- /usr/ports/finance/venice/pkg-descr 2013-01-14 17:55:05.000000000 +0100
+++ ./pkg-descr 2012-11-30 10:00:38.000000000 +0100
@@ -1,5 +1,3 @@
-[ excerpt taken from developer's web site ]
-
Venice is a stock market trading program that supports portfolio
management, charting, technical analysis, paper trading and
experimental methods like genetic programming. Venice runs in a
diff -ruN --exclude=3DCVS /usr/ports/finance/venice/pkg-plist ./pkg-plist
--- /usr/ports/finance/venice/pkg-plist 1970-01-01 01:00:00.000000000 +0100
+++ ./pkg-plist 2012-11-30 15:04:37.000000000 +0100
@@ -0,0 +1,24 @@
+bin/venice
+share/icons/hicolor/128x128/apps/venice.png
+share/icons/hicolor/32x32/apps/venice.png
+share/icons/hicolor/48x48/apps/venice.png
+share/icons/hicolor/64x64/apps/venice.png
+share/icons/hicolor/72x72/apps/venice.png
+share/icons/hicolor/96x96/apps/venice.png
+%%DATADIR%%/venice.jar
+share/pixmaps/venice.png
+@dirrm %%DATADIR%%
+@dirrmtry share/icons/hicolor/96x96/apps
+@dirrmtry share/icons/hicolor/96x96
+@dirrmtry share/icons/hicolor/72x72/apps
+@dirrmtry share/icons/hicolor/72x72
+@dirrmtry share/icons/hicolor/64x64/apps
+@dirrmtry share/icons/hicolor/64x64
+@dirrmtry share/icons/hicolor/48x48/apps
+@dirrmtry share/icons/hicolor/48x48
+@dirrmtry share/icons/hicolor/32x32/apps
+@dirrmtry share/icons/hicolor/32x32
+@dirrmtry share/icons/hicolor/128x128/apps
+@dirrmtry share/icons/hicolor/128x128
+@dirrmtry share/icons/hicolor
+@dirrmtry share/icons
=3D=3D=3D> Done
--MP_/a=_9TzkKIsQoeWPTFf82ITz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302231830.r1NIU1gd064187>