Date: Sun, 22 Sep 2002 13:40:17 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Jeff Roberson <jroberson@chesapeake.net> Cc: Robert Watson <rwatson@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/security/mac_biba mac_biba.c src/sys/security/mac_mls mac_mls.c Message-ID: <20020922132906.J12545-100000@gamplex.bde.org> In-Reply-To: <20020921224816.K43954-100000@mail.chesapeake.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 21 Sep 2002, Jeff Roberson wrote: > On Sun, 22 Sep 2002, Bruce Evans wrote: > > > On Sat, 21 Sep 2002, Robert Watson wrote: > > > > > rwatson 2002/09/21 11:29:38 PDT > > > > > > Modified files: > > > sys/security/mac_biba mac_biba.c > > > sys/security/mac_mls mac_mls.c > > > Log: > > > As INVARIANTS isn't supported for code that loads only as a kernel > > > module and is not linked into the base system, two KASSERT's rotted. > > > Fix them by fixing variable names. It would be really nice if > > ^^^^ nasty > > > opt_global.h was used when building modules as part of a buildkernel. > > > > > > Obtained from: TrustedBSD Project > > > Sponsored by: DARPA, Network Associates Laboratories > > > > Modules are bad enough without making ones that only work with 1 kernel. > > What if we were to allow modules to build in KASSERTS that were only > enabled if the kernel they were loaded into supported it? That seems like > the right solution here. I guess I have no objections to modules being compiled with options that are binary compatible with all kernels. I think KASSERTs already work almost right here. "options INVARIANTS" gives KASSERTs in modules, and these are supposed to work if the kernel was compiled with "options INVARIANT_SUPPORT". Last time I looked, INVARIANT_SUPPORT had a low cost so it might as well be standard. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020922132906.J12545-100000>