Date: Mon, 26 Jan 1998 08:53:45 PST From: Bill Fenner <fenner@parc.xerox.com> To: Bruce Evans <bde@zeta.org.au> Cc: freebsd-bugs@hub.freebsd.org, sprice@hiwaay.net Subject: Re: misc/1376 Message-ID: <98Jan26.085352pst.177476@crevenia.parc.xerox.com> In-Reply-To: Your message of "Mon, 26 Jan 98 06:29:38 PST." <199801261429.BAA31752@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans <bde@zeta.org.au> wrote: >The bzero seems to be a no-op, since tunattach() is only called once and >tunctl[] is statically initialized to 0. That was another reason that I was suspicious of the patch, but I figured I was just missing something since the PR originator seemed to think his patch fixed his problem. (Perhaps I'm making an assumption that the PR was based on having a problem as opposed to code inspection). It is clear, however, that tunattach() won't run multiple times even if it were called multiple times. Perhaps the real solution is to remove the other zero initializations to avoid confusing code inspectors. Bill
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?98Jan26.085352pst.177476>