Date: Tue, 24 Jul 2007 15:35:58 -0400 From: John Baldwin <jhb@freebsd.org> To: Robert Watson <rwatson@freebsd.org> Cc: arch@freebsd.org, gnn@freebsd.org, bz@freebsd.org, current@freebsd.og, freebsd-arch@freebsd.org Subject: Re: Removing NET_NEEDS_GIANT: first patch Message-ID: <200707241535.59867.jhb@freebsd.org> In-Reply-To: <20070724192023.N15979@fledge.watson.org> References: <20070724110908.T83919@fledge.watson.org> <200707241107.43047.jhb@freebsd.org> <20070724192023.N15979@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 24 July 2007 02:21:09 pm Robert Watson wrote: > > On Tue, 24 Jul 2007, John Baldwin wrote: > > > On Tuesday 24 July 2007 06:17:45 am Robert Watson wrote: > >> Patch attached, and also available at this URL: > > > > Possibly use mtx_assert() rather than KASSERT(mtx_owned()) in > > nfs_syscalls.c? > > Sounds good, I will make that change. I picked that new structure because it > most closely matched what was there, and what was there required a KASSERT > because it combined a variable check with a lock check, but the new code > doesn't require that. *nod* I'd figured as much. I'd of almost prefer that the previous code had been: if (!debug_mpsafenet) mtx_assert(...) FWIW. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707241535.59867.jhb>