Date: Tue, 7 Dec 1999 13:00:33 -0500 From: Garance A Drosihn <drosih@rpi.edu> To: current@FreeBSD.ORG, stable@FreeBSD.ORG Subject: [PATCHES] Two fixes for lpd/lpc for review and test Message-ID: <v04210102b472f8589876@[128.113.24.47]> In-Reply-To: <v04210106b45cb5d6b595@[128.113.24.47]> References: <v04210106b45cb5d6b595@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
Well, here's my third attempt to get someone to at least acknowledge
some minor patches for lpd. The patches are also covered in PR's,
as noted in the previous attempts. My theory is that my previous
attempts had a subject which made it sound like I was looking for
someone to *make* some fixes, as opposed to the fact that I already
have fixes for these known bugs and I thought someone with commit
privs might want to apply them to the official distribution.
In my next installment, I'm going to try a subject of
"Make Money Fast via Sex With Green Card Lawyers"
Although with this crowd I'd probably have better luck with
something like:
"I have vmware running native on FreeBSD 3.2-release"...
While I'm at it, I'd like to note another patch for lpd which
looked interesting. This one might be a bit too risky to get
into 3.4-release, but it would be nice to at least add it to
current. To quote from another message:
- - -
Date: Mon, 22 Nov 1999 20:08:13 +0100
From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
Subject: Enhancement for lpr (maybe for STABLE-3.4)
A while ago I sent a PR containing an enhancement
for lpr -r for the case that the file to be printed
is on the same filesystem as lpd's spooling directory.
The PR is bin/11997 and can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=11997
Maybe someone can look at it, review it and eventually
commit it to -STABLE (and current, of course). The patch
now runs nearly 2 years without problems and saves quite
a lot of time when printing large temporay files.
- - -
Note that the above patch not only saves time, but reduces
the amount of disk space needed in a print-spooling partition.
That may not seem like much of an issue when you're printing
10-Kbyte files, but when you're throwing around 200-Meg files
(for color plotters, for instance), then it can be very nice.
The text from my previous attempts follow.
- - - - - - - - - - - - - - - - - - - - - - - - -
At 5:04 PM -0500 11/20/99, Garance A Drosihn wrote:
>Back when we were closing in on the release date for 3.3, I sent
>the following message. As we now close in on the release date
>for 3.4, I thought I'd send it again, seeing that both of the
>problem reports are still marked "open", and neither of the two
>patches have been applied yet. (not even to current)
>
>These are both pretty tiny minor lovable cuddly changes... Any
>chance of getting them in for 3.4?
>
>Note that problem report bin/12912 probably depends on what
>umask is set when lpd starts up. The pr says "the problem
>doesn't seem to be reproducible", but reproducing the problem
>may depend on someone making a change elsewhere. Given that
>lpd uses the actual access-bit settings to govern it's behavior,
>then it should make sure the exactly-correct bit settings are
>set up when it creates the file.
>
>Also note that the fix for bin/9362, sent in as bin/13549,
>is also confirmed in bin/14975.
>
>>Date: Mon, 6 Sep 1999 18:14:55 -0500
>>To: current@FreeBSD.org
>>From: Garance A Drosihn <drosih@rpi.edu>
>>Subject: Two fixes for lpd/lpc (printing)
>>Cc: kheuer@gwdu60.gwdg.de
>>
>>I noticed problem-report bin/9362, which reported that the
>>'lpc start' command no longer works. (it claims to start
>>the queue, but it doesn't actually start it).
>>
>>I came up with a two or three line fix for that bug, and
>>sent it in as problem-report bin/13549. This patch should
>>work on both freebsd-current and freebsd-stable.
>>
>>I also noticed problem report bin/12912. This PR includes
>>a patch to make sure that if a lockfile does not already
>>exist, then it will be created such that the queue is both
>>"enabled" and "started". I have not tried this exact patch
>>yet, but here at RPI we've had a similar patch to lpd for a
>>long time. We add printer queues to a master printcap file,
>>which is then copied to a few hundred workstations. We really
>>don't want to have to run around all those workstations to
>>'enable' and 'start' a queue that we have just added. Perhaps
>>we have a different 'umask' setting when lpd starts up than
>>most freebsd sites do...
>>
>>Could some other people try these simple patches, and see
>>how well they work? I am hoping these could make it into
>>the next official release, although I realize that time is
>>rapidly running out for that! :-)
>
>---
>Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu
>Senior Systems Programmer or drosih@rpi.edu
>Rensselaer Polytechnic Institute
---
Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu
Senior Systems Programmer or drosih@rpi.edu
Rensselaer Polytechnic Institute
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?v04210102b472f8589876>