Date: Mon, 15 Jul 2002 09:05:42 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: keramida@FreeBSD.ORG Cc: des@ofug.org, bde@zeta.org.au, freebsd-audit@FreeBSD.ORG Subject: Re: bin/ln & WARNS=5 Message-ID: <20020715.090542.07693309.imp@bsdimp.com> In-Reply-To: <20020715114437.GA51994@hades.hell.gr> References: <20020715112116.GE50130@hades.hell.gr> <xzpsn2l8bob.fsf@flood.ping.uio.no> <20020715114437.GA51994@hades.hell.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20020715114437.GA51994@hades.hell.gr>
Giorgos Keramidas <keramida@FreeBSD.ORG> writes:
: On 2002-07-15 13:37 +0000, Dag-Erling Smorgrav wrote:
: > Giorgos Keramidas <keramida@FreeBSD.org> writes:
: > > What's wrong with sizeof(...)? I thought that style(9) was actually
: > > encouraging the use of parentheses for the arguments of sizeof, when
: > > it mentioned:
: > >
: > > Casts and sizeof's are not followed by a space. Note that
: > > indent(1) does not understand this rule.
: >
: > There are two different cases - one is "sizeof(type)" which requires
: > parentheses, the other is "sizeof variable" which doesn't. In the
: > latter case, the rule about avoiding unnecessary parentheses applies.
That's not always the case. sizeof type always works too. The
convention is that sizeof(foo) is done in BSD sources.
: Ah ! [ enlightenment ]
:
: That would require a major style sweep in ln.c though. Such changes
: should be done in a separate commit, right?
Yes, they are done with a separate commit, but not when it is the
wrong thing to do. Leave sizeof(var) alone please.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020715.090542.07693309.imp>