Date: Thu, 29 Jul 2010 02:03:56 -0500 From: Mark Linimon <linimon@lonesome.com> To: Doug Barton <dougb@FreeBSD.org> Cc: jhell <jhell@DataIX.net>, skv@FreeBSD.org, ports@FreeBSD.org, perl@FreeBSD.org, portmgr@FreeBSD.org Subject: Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk) Message-ID: <20100729070356.GA25380@lonesome.com> In-Reply-To: <alpine.BSF.2.00.1007282321490.1718@qbhto.arg> References: <20100718223830.GA10338@lonesome.com> <4C43B4A5.5080104@FreeBSD.org> <4C44D01C.70704@p6m7g8.com> <alpine.BSF.2.00.1007192043010.1694@qbhto.arg> <4C451F06.8020106@p6m7g8.com> <alpine.BSF.2.00.1007192102470.1694@qbhto.arg> <4C453409.8000201@p6m7g8.com> <alpine.BSF.2.00.1007192254160.1725@qbhto.arg> <20100729041455.GA21455@lonesome.com> <alpine.BSF.2.00.1007282321490.1718@qbhto.arg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 28, 2010 at 11:47:11PM -0700, Doug Barton wrote: > When I asked you what was necessary to test this, you said all that was > necessary was to define _PERL_REFACTORING_COMPLETE. And my memory slipped. The explanation, however, was correct: the problem is that if you unconditionally include bsd.perl.mk, everything works, and if you conditionally include it, it doesn't. If you didn't patch the code that does the conditional include, then you didn't test for the actual problem. This is a case of believing the author and/or the documentation, and not looking at the code. I made a mistake; it was not intentional; I'm sorry. mcl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100729070356.GA25380>