Date: Wed, 26 Aug 1998 12:32:40 +1000 From: Stephen McKay <syssgm@dtir.qld.gov.au> To: Doug Rabson <dfr@nlsystems.com> Cc: "John S. Dyson" <dyson@iquest.net>, freebsd-current@FreeBSD.ORG, syssgm@dtir.qld.gov.au Subject: Re: Serious bug in vm_page.h in current Message-ID: <199808260232.MAA06321@nymph.dtir.qld.gov.au> In-Reply-To: <Pine.BSF.4.01.9808251908210.17263-100000@herring.nlsystems.com> from Doug Rabson at "Tue, 25 Aug 1998 19:10:48 %2B0100" References: <Pine.BSF.4.01.9808251908210.17263-100000@herring.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, 25th August 1998, Doug Rabson wrote: >On Tue, 25 Aug 1998, Stephen McKay wrote: > >> On Tuesday, 25th August 1998, Doug Rabson wrote: >> >> Purely on naming now, the new inline vm_object_set_flag() and friends are >> well named. The PAGE_BUSY and PAGE_WAKEUP macros, etc, should be similarly >> named inline functions. For example, vm_page_busy_add() and vm_page_wakeup(). >I chose the PAGE_XXX type names since they seemed to follow the existing >macros in vm_page.h. I am perfectly happy to change them to inline >functions with a similar naming convention to the ones in vm_object as >long as all of the other PAGE_XXX macros change at the same time. I was perhaps too brief. All the PAGE_XXX macros would have to change to be consistent (hopefully changed to inline functions at the same time). I had noticed that you were being consistent with existing naming, but the naming used in vm_object.h is clearly better. >The i/o count should certainly have a less confusing name. Indeed. I'm sure you will come up with a good one. Stephen. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808260232.MAA06321>