Date: Sat, 19 Jul 2014 18:02:28 +0200 From: olli hauer <ohauer@gmx.de> To: Kurt Jaeger <pi@FreeBSD.org> Cc: Frederic Culot <culot@FreeBSD.org>, apache@freebsd.org, skv@FreeBSD.org Subject: Re: www/p5-libapreq2: libtool fix, strip libs, pkg-plist followup, p5-fix Message-ID: <53CA9694.4040409@gmx.de> In-Reply-To: <20140719151508.GB33102@f10.opsec.eu> References: <20140608081334.GK1427@f10.opsec.eu> <20140608083407.GL1427@f10.opsec.eu> <20140608083636.GM1427@f10.opsec.eu> <20140608085842.GO1427@f10.opsec.eu> <53945E98.3080408@gmx.de> <20140610094949.GY3484@f10.opsec.eu> <539752DE.5060208@gmx.de> <20140719151508.GB33102@f10.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-07-19 17:15, Kurt Jaeger wrote: > Hello, > >>> Back to my proposed change for www/libapreq2 and this question: >>> >>>>> Would it be more useful to make the slave port (p5-libapreq2) >>>>> a seperate port depending on the other ? >>> >>> Looking at the pkg-plist and Makefile mess: Is it really useful >>> to have this master/slave port or should I split and depend on libapreq2 ? > > Attached are two diffs for both ports that seperate them. > >> running a short grep over the tree shows there are only two libapreq2 consumers >> - www/mod_amazon_proxy >> - www/p5-libapreq2 >> >> but eleven p5-libapreq consumers >> - net-mgmt/netdisco >> - net-mgmt/netdot >> - www/foswiki-ModPerlEngineContrib >> - www/p5-Apache-Gallery >> - www/p5-Apache2-SiteControl >> - www/p5-CGI-Application-Plugin-Apache >> - www/p5-HTML-Mason >> - www/p5-Maypole >> - www/rt38 >> - www/rt40.cpan >> - www/rt42.cpan > > I ran a bulk poudriere run with this: > > www/mod_amazon_proxy > net-mgmt/netdisco > net-mgmt/netdot > www/foswiki-ModPerlEngineContrib > www/p5-Apache-Gallery > www/p5-Apache2-SiteControl > www/p5-CGI-Application-Plugin-Apache > www/p5-HTML-Mason > www/p5-Maypole > www/rt38 > www/rt40 > www/rt42 > > and DEFAULT_VERSIONS=perl5=5.20 apache=2.2 > > without problems on 10amd64 and 91amd64. > > Attached are the two diffs, please comment, and if it's OK, please > approve. > > I'll also update 191161 for testing. > Hi Kurt, seems some files are missing in the p5-libapreq2.diff >From the p5-libapreq2.diff Only in p5-libapreq2: distinfo Only in p5-libapreq2: files Only in p5-libapreq2: pkg-descr Only in p5-libapreq2: pkg-plist Can you shape a svn diff? $ mkdir fix_libapreq $ cd fix_libapreq $ svn checkout --depth empty svn+ssh://svn.freebsd.org/ports/head ports $ cd ports $ svn up --set-depth empty www $ svn up www/libapreq2 www/p5-libapreq2 # apply your patches $ svn diff > my.diff If your test build was OK feel free to commit your patches. -- olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53CA9694.4040409>