Date: Sat, 30 Aug 2014 13:30:04 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 193146] New: [PATCH] getblk: Assert that bsize is non-zero Message-ID: <bug-193146-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193146 Bug ID: 193146 Summary: [PATCH] getblk: Assert that bsize is non-zero Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: conrad.meyer@isilon.com Created attachment 146535 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=146535&action=edit (Applies to CURRENT with -p0.) If !vn_isdisk(vp) and bo_bsize is zero, getblk() will calculate offsets for different blknos as zero, and create multiple bufs pointing at the same section of VM object (due to offset being zero). As you might imagine, this is pretty bad. This patch attempts to head off developer errors like bo_bsize == 0 quickly with a KASSERT. Sponsored by: EMC / Isilon storage division -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193146-8>