Date: Fri, 14 Sep 2018 16:39:27 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Yuri Victorovich <yuri@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r479762 - head/science/cp2k Message-ID: <lg84-qh28-wny@FreeBSD.org> In-Reply-To: <20180914102558.e4tuqrxeu7jvyyu4@atuin.in.mat.cc> (Mathieu Arnold's message of "Fri, 14 Sep 2018 12:25:58 %2B0200") References: <201809140758.w8E7w5D9093846@repo.freebsd.org> <20180914102558.e4tuqrxeu7jvyyu4@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Arnold <mat@FreeBSD.org> writes:
> On Fri, Sep 14, 2018 at 07:58:05AM +0000, Yuri Victorovich wrote:
>
>> +.include <bsd.port.options.mk>
>> +
>> +.if ${PORT_OPTIONS:MOPENMP} || ${PORT_OPTIONS:MOPENMP_MPI}
>> +pre-configure:
>> + @if [ ! -e ${LOCALBASE}/lib/libfftw3_omp.so ] ; then \
>> + ${ECHO_MSG} "The OPENMP and OPENMP_MPI options require math/fftw3" ; \
>> + ${ECHO_MSG} "to be built and installed with the OPENMP option ON" ; \
>> + exit 1; \
>> + fi
>> +.endif
>
> I keep wondering why you always try so hard to invent new ways of doing
> things.
>
> .if ${PORT_OPTIONS:MOPENMP} || ${PORT_OPTIONS:MOPENMP_MPI}
> . if !exists(${LOCALBASE}/lib/libfftw3_omp.so)
> BROKEN= The OPENMP and OPENMP_MPI options require math/fftw3 to be built and installed with the OPENMP option ON
> . endif
> .endif
See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=166279 for an
example where your approach fails.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?lg84-qh28-wny>