Date: Wed, 6 Nov 2013 13:55:14 +0000 (UTC) From: "Ganael LAPLANCHE" <martymac@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Ganael LAPLANCHE <martymac@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332953 - head/benchmarks/nttcp Message-ID: <20131106135212.M16907@FreeBSD.org> In-Reply-To: <20131106081815.GB90001@FreeBSD.org> References: <201311060811.rA68BbBe077262@svn.freebsd.org> <20131106081815.GB90001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 6 Nov 2013 08:18:15 +0000, Alexey Dokuchaev wrote
Hi Alexey,
> > ALL_TARGET= nttcp
> > -MAN1= nttcp.1
> > -PLIST_FILES= bin/nttcp
> > +PLIST_FILES= bin/nttcp man/man1/nttcp.1.gz
>
> We usually try to move out PLIST_* knobs in separate block.
You mean having a blank line between MAN1 and PLIST_FILES, right ?
> > - ${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${PREFIX}/bin/
> > - ${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${PREFIX}/man/man1/
> > + ${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${STAGEDIR}${PREFIX}/bin/
> > + ${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${STAGEDIR}${PREFIX}/man/man1/
>
> Manual pages should be installed relative to MAN[n]PREFIX, not
> PREFIX.
Oops, thanks for having spotted this ! I'll fix that ASAP.
Best regards,
--
Ganael LAPLANCHE <ganael.laplanche@martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131106135212.M16907>