Date: Mon, 9 Feb 2015 12:19:26 -0800 From: hiren panchasara <hiren@strugglingcoder.info> To: Randall Stewart <rrs@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r278469 - in head/sys: kern sys Message-ID: <20150209201926.GF10438@strugglingcoder.info> In-Reply-To: <201502091919.t19JJjbg061542@svn.freebsd.org> References: <201502091919.t19JJjbg061542@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--rMWmSaSbD7nr+du9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 02/09/15 at 07:19P, Randall Stewart wrote: > Author: rrs > Date: Mon Feb 9 19:19:44 2015 > New Revision: 278469 > URL: https://svnweb.freebsd.org/changeset/base/278469 >=20 > Log: > This fixes two conditions that can incur when migration > is being done in the callout code and harmonizes the macro > use.: > 1) The callout_active() will lie. Basically if a migration > is occuring and the callout is about to expire and the > migration has been deferred, the callout_active will no > longer return true until after the migration. This confuses > and breaks callers that are doing callout_init(&c, 1); such > as TCP. > 2) The migration code had a bug in it where when migrating, if > a two calls to callout_reset came in and they both collided with > the callout on the wheel about to run, then the second call to > callout_reset would corrupt the list the callout wheel uses > putting the callout thread into a endless loop. > 3) Per imp, I have fixed all the macro occurance in the code that > were for the most part being ignored. > =20 > Phabricator D1711 and looked at by lstewart and jhb and sbruno. > Reviewed by: kostikbel, imp, adrian, hselasky > MFC after: 3 days > Sponsored by: Netflix Inc. Thanks Randall for the fix. For future reference, correct way to specify phabric review is: Differential Revision: https://reviews.freebsd.org/D1711=20 This triggers changes to the review on phabricator with reference to this commit. Cheers, Hiren --rMWmSaSbD7nr+du9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJU2RZNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lsHAH/REclGA0grPhcrccQAuNRKC0 WDITbuzvrR9CHqs+1Wv1CvxbvcDKijP+itfpZG3k6MJWqjgLm4TUO94UYTq8oqIg tD3Wi/p12D7w5x7FYDgebAXKDEaCdIczv0Aiho4pwF1aoRQ2r9EzRJAuzAzqEFX3 4z6gHqXAkqGEYPKIwPIEO3tPE3JflBqDUhIt64cGrZHGsiaNhhw2zrrgyaga6wFq PS62XDV+y2dDnv/m3i+gz1Vw34uFq6okGf6tYWYYuM62/SBsyT8tO3FbvHlRovUf XeQbgpcPZmuUPhSvnPGT4wWjlftIZFXhA4CFjrcjN8QZipXOizffMlqES98vziQ= =yMIe -----END PGP SIGNATURE----- --rMWmSaSbD7nr+du9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150209201926.GF10438>