Date: Tue, 22 Aug 2006 17:14:16 -0400 From: John Baldwin <jhb@freebsd.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: pyunyh@gmail.com, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, glebius@freebsd.org, ru@freebsd.org, yongari@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c Message-ID: <200608221714.17544.jhb@freebsd.org> In-Reply-To: <20060822.143605.1102534622.imp@bsdimp.com> References: <20060822082237.GC41304@rambler-co.ru> <20060822101012.GC43494@rambler-co.ru> <20060822.143605.1102534622.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 22 August 2006 16:36, M. Warner Losh wrote: > In message: <20060822101012.GC43494@rambler-co.ru> > Ruslan Ermilov <ru@FreeBSD.org> writes: > : It's still a watchdog event. We can make it a separate counter, > : like watchdog_tx_event, and not add it to oerrors, but still show > : it in em_print_hw_stats(). It'd be useful to have this statistics > : available. > > I've noticed some drivers have started to export stats via sysctls in > the dev tree. Maybe that's where it should go? > > I've used it for cbb, for example, to report things that are usually > hidden behind bootverbose (more could be useful here): > > dev.cbb.1.pribus: 6 > dev.cbb.1.secbus: 7 > dev.cbb.1.subbus: 7 > > the code is real simple in the init routine to hook up these sysctl to > a softc variable... em already has several: dev.em.0.debug_info: -1 dev.em.0.stats: -1 dev.em.0.rx_int_delay: 0 dev.em.0.tx_int_delay: 66 dev.em.0.rx_abs_int_delay: 66 dev.em.0.tx_abs_int_delay: 66 -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608221714.17544.jhb>