Date: Thu, 17 Dec 2020 03:43:05 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 232921] freebsd-update upgrade does not execute pwd_mkdb for ntpd Message-ID: <bug-232921-227-R3jC0EKKYp@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-232921-227@https.bugs.freebsd.org/bugzilla/> References: <bug-232921-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232921 --- Comment #13 from commit-hook@FreeBSD.org --- A commit references this bug: Author: kevans Date: Thu Dec 17 03:42:54 UTC 2020 New revision: 368713 URL: https://svnweb.freebsd.org/changeset/base/368713 Log: freebsd-update: unconditionally regenerate passwd/login.conf files The existing logic is nice in theory, but in practice freebsd-update will not preserve the timestamps on these files. When doing a major upgrade, e= .g. from 12.1-RELEASE -> 12.2-RELEASE, pwd.mkdb et al. appear in the INDEX and we clobber the timestamp several times in the process of packaging up the existing system into /var/db/freebsd-update/files and extracting for comparisons. This leads to these files not getting regenerated when they'= re most likely to be needed. Measures could be taken to preserve timestamps, but it's unclear whether the complexity and overhead of doing so is really outweighed by the margi= nal benefit. I observed this issue when pkg subsequently failed to install a package t= hat wanted to add a user, claiming that the user was removed in the process. bapt@ pointed to this pre-existing bug with freebsd-update as the cause. PR: 234014, 232921 Reviewed by: bapt, emaste MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D27635 Changes: head/usr.sbin/freebsd-update/freebsd-update.sh --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-232921-227-R3jC0EKKYp>