Date: Thu, 13 Dec 2018 21:02:25 -1000 From: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r487403 - head/databases/puppetdb-cli Message-ID: <20181214070225.GA13003@blogreen.org> In-Reply-To: <sgz0-u1l5-wny@FreeBSD.org> References: <201812140259.wBE2xbuT015992@repo.freebsd.org> <sgz0-u1l5-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 14, 2018 at 06:19:50AM +0100, Jan Beich wrote: > Romain Tarti=E8re <romain@FreeBSD.org> writes: >=20 > > +BROKEN_SSL_REASON_libressl=3D Needs an old version of OpenSSL (older t= han 1.1) >=20 > Does it build fine with DEFAULT_VERSIONS+=3Dlibressl-devel ? Of course not, good catch! Probably the same for openssl-devel but it seems absent as of today, so I don't know if we should add it. > > +.include <bsd.port.pre.mk> >=20 > .include <bsd.port.options.mk> would have been enough. Yes, it seems to be okay too. I was following https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#dads-after-port-mk > > +.if ${OSVERSION} >=3D 1200085 >=20 > Checking OSVERSION without OPSYS is illegal. DragonFly has OSVERSION=3D99= 99999 > with LibreSSL 2.4.4 in base. >=20 > https://github.com/DragonFlyBSD/DPorts/blob/f18014a15a13/Mk/bsd.port.mk#L= 1184 > https://github.com/DragonFlyBSD/DragonFlyBSD/blob/bd84e83893b2/crypto/lib= ressl/README.DRAGONFLY Fixed! > > +BROKEN_SSL+=3D base >=20 > BROKEN_SSL=3Dbase is *not supported* by USES=3Dssl, and BROKEN_SSL cannot= set > after bsd.port.pre.mk because USES=3Dssl was already processed by that ti= me. D'oh! Maybe this information may have it's place in the Porter's Handbook: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#uses-ssl I tried to workaround this by testing OPSYS && OSVERSION && SSL_DEFAULT and setting BROKEN if all conditions are met. Quite ugly, but should get the work done. If you see a better way to fix this, please tell me. Thanks! --=20 Romain Tarti=E8re <romain@FreeBSD.org> http://people.FreeBSD.org/~romain/ pgp: 8234 9A78 E7C0 B807 0B59 80FF BA4D 1D95 5112 336F (ID: 0x5112336F) (plain text =3Dnon-HTML=3D PGP/GPG encrypted/signed e-mail much appreciated) --FL5UXtIhxfXey3p5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEgjSaeOfAuAcLWYD/uk0dlVESM28FAlwTVX4ACgkQuk0dlVES M2+yJwv/etc/eHOcRNjg3Oiov0/TYobvFTtKJ8VU0LHj6NoCrYtiX1UKcrhJbWYl jznJBO19xGMI64RV0yE2w6gFu34jZJjyEF23lVbKvSPicEgUKHeM+yYGiab/CzYs eDmQFLr3Yj0uBi+p3z9iHJWjHKBCNTIZZgxfx77+nWUg+CwdtJTYGS0RSQSS/fdu +3+zjgecLiZ7iFJMvBi0aH9jUk/iTiQfR8yTVif3jhUzocgAtOBp1HNXqtfOMpmf 9aeXsvek/dQXY3GKm4gK6gWVdSGpI0LSqB1RT0zSKmh6I6Cxrn1Ub3Exz8Lzd4Dd /77EZLrtZDNnuBYot4kQq2HFe/AGfjIvIBty67M3fOe9cnZRITLQdUmW4VWm5wxs SAS7InhJDCum6J9xafn1fFvkGMTkY89FbaZdwL7KoV3lJFyGoR7UVhQRh8bEnAHX WAD6twtYMMZeuATg79F7iWp2Ip/Fc0427+dIP6zn/RS21kiPdvAjsvNDaRpyuvam W0Q1ylCe =T/Hc -----END PGP SIGNATURE----- --FL5UXtIhxfXey3p5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181214070225.GA13003>