Date: Sat, 1 Dec 2018 01:54:07 +0000 From: Steven Hartland <steven.hartland@multiplay.co.uk> To: Eugene Grosbein <eugen@grosbein.net> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Cy Schubert <Cy.Schubert@cschubert.com> Subject: Re: svn: head/usr.bin: . trim Message-ID: <3c0dae49-84ac-a3ef-32c7-f796e3eec16c@multiplay.co.uk> In-Reply-To: <51e0273e-2259-28c9-1872-c3c971e4ece0@grosbein.net> References: <20181130011713.42B641D27@spqr.komquats.com> <0e233c0c-6c80-4618-9618-48162362a849@multiplay.co.uk> <20181130084955.o4loxtuswdsvzksy@ivaldir.net> <20181130105714.GA84052@FreeBSD.org> <15e4f063-d081-9c38-be3e-44bc622cc50e@freebsd.org> <20181130113422.GA14353@FreeBSD.org> <df7ba408-2caf-92fb-8083-26bad4055bb3@freebsd.org> <20181130115515.GA28531@FreeBSD.org> <a77e429a-7fa3-2b87-044d-260be380d631@grosbein.net> <20181130125645.GA97463@FreeBSD.org> <CANCZdfpEgOrPDbwe%2BnKAYdi6wo-=odpcuUnj4fjYrsUeTC5Xpw@mail.gmail.com> <2ef3034e-6c4c-4fb7-3c7d-7cb41e4faac5@grosbein.net> <864fc11c-6554-f8de-5a58-dfee09a23803@multiplay.co.uk> <51e0273e-2259-28c9-1872-c3c971e4ece0@grosbein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30/11/2018 22:09, Eugene Grosbein wrote: > 01.12.2018 4:29, Steven Hartland wrote: > >> On 30/11/2018 21:16, Eugene Grosbein wrote: >>> 30.11.2018 21:23, Warner Losh wrote: >>> >>>> So I'm back to my point: we should just put it into dd and move on with our lives. It's really the right place for it. >>> Why can't we have two implementations? Diversity is good thing. >>> >>> I can imagine erasing a partition with ZFS Cache or ZIL inside and >>> "trim /dev/da0p2 /dev/da0p3" looks much better :-) >> ZFS already does that no need for a separate tool > Think of media taken out of (possibly already dead) ZFS-based to UFS-only system. > > By the way, how exactly do you trim previously ZIL partition withing working ZFS-based system? > You could use camcontrol which can perform a secure erase on the device, but that's obviously device wide not a specific partition. What I was referring to is ZFS performs a delete of blocks when it initializes a volume, so there's usually no need to perform a manual step there. For reference this behavior can be disabled by setting vfs.zfs.vdev.trim_on_init=0 Regards Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3c0dae49-84ac-a3ef-32c7-f796e3eec16c>