Date: Sun, 1 Jul 2007 12:53:06 GMT From: Michael Scheidell <scheidell@secnap.net> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/114188: [maintainer-update] p5-Mail-SpamAssassin deletes /var/lib even if used Message-ID: <200707011253.l61Cr6h4051666@www.freebsd.org> Resent-Message-ID: <200707011300.l61D0H3U094352@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 114188
>Category: ports
>Synopsis: [maintainer-update] p5-Mail-SpamAssassin deletes /var/lib even if used
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Sun Jul 01 13:00:15 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Michael Scheidell
>Release: 5.5
>Organization:
SECNAP
>Environment:
NA
>Description:
PR 112502 erases /var/lib directory during deinstall of SpamAssassin, even if used by other programs
(Thanks Henrik Olsen)
This patch fixes this.
Second patch adds sa-compile if selected. (spamd fails if user originally selected sa-compile and did not RUN sa-compile, due to missing libraries)
Note: I do NOT need to bump portrevision since no additional functionality added, and if user already deleted his /var/lib, this won't bring it back
#1. no additional functionality added
#2. if sa-compile not run, spamd didn't start, so user had to do it.
#3, users who nightly do a portupgrade -R don't need this to run.
>How-To-Repeat:
portupgrade p5-Mail-SpamAssassin || make deinstall
patch tried, seems to work:
Deinstalling p5-Mail-SpamAssassin-3.2.1
rmdir: /var/lib: Directory not empty
pkg_delete: unexec command for 'rmdir /var/lib' failed
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
To delete spamd user permanently, use 'rmuser spamd'
mirror# ls /var/lib/spamassassin/
ls: /var/lib/spamassassin/: No such file or directory
mirror# ls /var/lib
keep.txt
>Fix:
diff -bBru /var/tmp/p5-Mail-SpamAssassin/ ./
diff -bBru /var/tmp/p5-Mail-SpamAssassin/Makefile ./Makefile
--- /var/tmp/p5-Mail-SpamAssassin/Makefile Sat Jun 16 18:17:03 2007
+++ ./Makefile Sun Jul 1 08:34:14 2007
@@ -252,6 +252,10 @@
@[ -f ${PREFIX}/etc/mail/spamassassin/v320.pre ] || \
${CP} ${PREFIX}/etc/mail/spamassassin/v320.pre.sample \
${PREFIX}/etc/mail/spamassassin/v320.pre
+.if defined(WITH_SACOMPILE)
+ @[ -x ${PREFIX}/bin/sa-compile ] && \
+ ${PREFIX}/bin/sa-compile
+.endif
.if !defined(NOPORTDOCS)
@${MKDIR} ${DOCSDIR} ${DOCSDIR}/sql ${DOCSDIR}/ldap
diff -bBru /var/tmp/p5-Mail-SpamAssassin/pkg-plist ./pkg-plist
--- /var/tmp/p5-Mail-SpamAssassin/pkg-plist Sat Jun 16 18:17:03 2007
+++ ./pkg-plist Sun Jul 1 08:44:58 2007
@@ -169,9 +169,9 @@
%%DATADIR%%/languages
%%DATADIR%%/sa-update-pubkey.txt
%%DATADIR%%/user_prefs.template
-@unexec rm -rf %D/libdata/spamassassin || true
-@unexec rm -rf /var/lib/spamassassin || true
-@unexec rm -rf /var/lib || true
+@unexec rm -rf /var/lib/spamassassin/3.* || true
+@unexec rmdir /var/lib/spamassassin
+@unexec rmdir /var/lib
@dirrm %%DATADIR%%
@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Mail/SpamAssassin
@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Mail
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707011253.l61Cr6h4051666>