Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Aug 2013 08:57:30 -0700
From:      Steve Kargl <sgk@troutmask.apl.washington.edu>
To:        David Chisnall <theraven@freebsd.org>
Cc:        "Sam Fourman Jr." <sfourman@gmail.com>, toolchain@freebsd.org, Boris Samorodov <bsam@passap.ru>, FreeBSD Current <current@freebsd.org>, Slawa Olhovchenkov <slw@zxy.spb.ru>
Subject:   Re: GCC withdraw
Message-ID:  <20130825155730.GA59962@troutmask.apl.washington.edu>
In-Reply-To: <1C36387A-B744-4E05-892E-AE2581D7E1ED@freebsd.org>
References:  <20130823111647.GT2951@home.opsec.eu> <521745F2.8050607@passap.ru> <CAOFF%2BZ3vbOgMO7T-BKZnhKte6=rFoGcdYcft5kpAgNH2my1JKg@mail.gmail.com> <20130824115158.GA88999@zxy.spb.ru> <EC9008A3-1737-470F-9067-C38FF13CFA20@FreeBSD.org> <20130824154217.GE3796@zxy.spb.ru> <20130824224204.GH3796@zxy.spb.ru> <D6A8F21E-C9AD-48C1-892E-80048343DCBA@freebsd.org> <20130824230615.GA55855@troutmask.apl.washington.edu> <1C36387A-B744-4E05-892E-AE2581D7E1ED@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Aug 25, 2013 at 11:08:57AM +0100, David Chisnall wrote:
> On 25 Aug 2013, at 00:06, Steve Kargl <sgk@troutmask.apl.washington.edu> wrote:
> 
> > On Sat, Aug 24, 2013 at 11:44:38PM +0100, David Chisnall wrote:
> >> On 24 Aug 2013, at 23:42, Slawa Olhovchenkov <slw@zxy.spb.ru> wrote:
> >> 
> >>> And i found PR about clang and mplayer: ports/176272
> >>> This PR contains log with build error log.
> >> 
> >> Please file clang bugs at http://llvm.org/bugs/
> >> 
> > 
> > As if this is going to help.
> > 
> > http://llvm.org/bugs/show_bug.cgi?id=8532
> > 
> > 2 years, 9 month and counting.
> 
> This bug relates to a corner case in complex floating point support,
> which GCC in base doesn't get right either,

GCC addressed issue in 4.5.0.  I don't necessarily agree with
the fix, but gcc did not ignore it.  I understand why FreeBSD has 
not updated to a newer gcc base.

> and which affects a tiny proportion of users

yep, anyone using complex arithmetic.

> and which comes with a hypothetical test case

Of course, it is a trivial testcase.  It was meant to be trivial to
demonstrate the bug and aid the compiler writer in fixing it.

> but no evidence that any real-world code is affected by it.

http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/147599

> If you have some real-world code that is compiled correctly
> by GCC but incorrectly by clang as a result of this, then
> please update the bug.

Go read FreeBSD libm's code where I (and now others) had/have
to jump through hoops with cpack[f|l] functions to avoid the 
problem.  

> Oh, and it's worth noting that clang, as an extension, supports
> using initialiser lists to create complex values and so this
> particular case is trivial to avoid if you use this feature,
> which you will if you create complex numbers using the macro that
> the C specification introduced specifically to avoid this case.  

See msun/src/math_private.h.  

But, the above is irrelevant.  You missed my point, so to
be blunt.  Reporting the bug to llvm does not mean that it
will be fixed.  More importantly the problem with mplayer
and clang should be reported/recorded in FreeBSD's bug
database where others can find the issue when clang fails
to build mplayer.  The mplayer maintainer can either 
fix the problem or escaluate the issue upstream.

-- 
Steve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130825155730.GA59962>