Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Sep 2013 19:48:15 +0200
From:      Juergen Lock <nox@jelal.kn-bremen.de>
To:        Juergen Lock <nox@FreeBSD.org>
Cc:        svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: svn commit: r326423 - in head/emulators/qemu-devel: . files
Message-ID:  <20130905174815.GA68853@triton8.kn-bremen.de>
In-Reply-To: <201309051739.r85HdPNk083368@svn.freebsd.org>
References:  <201309051739.r85HdPNk083368@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 05, 2013 at 05:39:25PM +0000, Juergen Lock wrote:
> Author: nox
> Date: Thu Sep  5 17:39:25 2013
> New Revision: 326423
> URL: http://svnweb.freebsd.org/changeset/ports/326423
> 
> Log:
>   - Add patch to fix pcnet-pci NIC big endian guests like MIPS Malta: [1]
>   
Language fail, there's a "for" missing:

 Add patch to fix pcnet-pci NIC for big endian guests like MIPS Malta: [1]

 Sigh... :/
	Juergen

>   	http://lists.nongnu.org/archive/html/qemu-stable/2013-08/msg00217.html
>   
>     See also gonzo's blog post:
>   
>   	http://kernelnomicon.org/?p=401
>   
>   - Bump PORTREVISION.
>   
>   Submitted by:	gonzo (via irc) [1]
>   Obtained from:	qemu upstream [1]
> 
> Added:
>   head/emulators/qemu-devel/files/patch-hw-net-pcnet-pci.c   (contents, props changed)
> Modified:
>   head/emulators/qemu-devel/Makefile
> 
> Modified: head/emulators/qemu-devel/Makefile
> ==============================================================================
> --- head/emulators/qemu-devel/Makefile	Thu Sep  5 17:37:22 2013	(r326422)
> +++ head/emulators/qemu-devel/Makefile	Thu Sep  5 17:39:25 2013	(r326423)
> @@ -3,6 +3,7 @@
>  
>  PORTNAME=	qemu
>  PORTVERSION=	1.6.0
> +PORTREVISION=	1
>  CATEGORIES=	emulators
>  MASTER_SITES=	http://wiki.qemu.org/download/:release \
>  		LOCAL/nox:snapshot
> 
> Added: head/emulators/qemu-devel/files/patch-hw-net-pcnet-pci.c
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/emulators/qemu-devel/files/patch-hw-net-pcnet-pci.c	Thu Sep  5 17:39:25 2013	(r326423)
> @@ -0,0 +1,48 @@
> +From: aurelien@aurel32.net (Aurelien Jarno)
> +Subject: [Qemu-devel] [PATCH] pcnet-pci: mark I/O and MMIO as LITTLE_ENDIAN
> +Date: Wed, 28 Aug 2013 14:17:39 +0200
> +Message-ID: <1377692259-19959-1-git-send-email-aurelien@aurel32.net>
> +To: qemu-devel@nongnu.org
> +Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-stable@nongnu.org,
> +        Aurelien Jarno <aurelien@aurel32.net>
> +
> +Now that the memory subsystem is propagating the endianness correctly,
> +the pcnet-pci device should have its I/O ports and MMIO memory marked
> +as LITTLE_ENDIAN, as PCI devices are little endian.
> +
> +This makes the pcnet-pci NIC to work again on big endian MIPS Malta
> +(default NIC).
> +
> +Cc: qemu-stable@nongnu.org
> +Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> +---
> + hw/net/pcnet-pci.c |    4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c
> +index a893165..865f2f0 100644
> +--- a/hw/net/pcnet-pci.c
> ++++ b/hw/net/pcnet-pci.c
> +@@ -134,7 +134,7 @@ static void pcnet_ioport_write(void *opaque, hwaddr addr,
> + static const MemoryRegionOps pcnet_io_ops = {
> +     .read = pcnet_ioport_read,
> +     .write = pcnet_ioport_write,
> +-    .endianness = DEVICE_NATIVE_ENDIAN,
> ++    .endianness = DEVICE_LITTLE_ENDIAN,
> + };
> + 
> + static void pcnet_mmio_writeb(void *opaque, hwaddr addr, uint32_t val)
> +@@ -256,7 +256,7 @@ static const MemoryRegionOps pcnet_mmio_ops = {
> +         .read = { pcnet_mmio_readb, pcnet_mmio_readw, pcnet_mmio_readl },
> +         .write = { pcnet_mmio_writeb, pcnet_mmio_writew, pcnet_mmio_writel },
> +     },
> +-    .endianness = DEVICE_NATIVE_ENDIAN,
> ++    .endianness = DEVICE_LITTLE_ENDIAN,
> + };
> + 
> + static void pci_physical_memory_write(void *dma_opaque, hwaddr addr,
> +-- 
> +1.7.10.4
> +
> +
> +



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130905174815.GA68853>