Date: Tue, 16 Mar 2021 09:43:35 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Emmanuel Vadot <manu@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0006530aa14b - main - include: Remove symlink installation Message-ID: <YFBhp6Zd8jUDFjru@kib.kiev.ua> In-Reply-To: <20210316083957.540d3978e5b0160db2104fa1@bidouilliste.com> References: <202103160613.12G6DLYL061995@gitrepo.freebsd.org> <YFBVlxZ1vXTdd3yu@kib.kiev.ua> <20210316081214.0ba83981a37b8b3b9e5589bd@bidouilliste.com> <YFBbkG1Utkxzr3JZ@kib.kiev.ua> <20210316083957.540d3978e5b0160db2104fa1@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 16, 2021 at 08:39:57AM +0100, Emmanuel Vadot wrote: > On Tue, 16 Mar 2021 09:17:36 +0200 > Konstantin Belousov <kostikbel@gmail.com> wrote: > > > On Tue, Mar 16, 2021 at 08:12:14AM +0100, Emmanuel Vadot wrote: > > > On Tue, 16 Mar 2021 08:52:07 +0200 > > > Konstantin Belousov <kostikbel@gmail.com> wrote: > > > > > > > On Tue, Mar 16, 2021 at 06:13:21AM +0000, Emmanuel Vadot wrote: > > > > > The branch main has been updated by manu: > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=0006530aa14b9df56f88df7d819fae89b115d865 > > > > > > > > > > commit 0006530aa14b9df56f88df7d819fae89b115d865 > > > > > Author: Emmanuel Vadot <manu@FreeBSD.org> > > > > > AuthorDate: 2021-03-16 06:12:53 +0000 > > > > > Commit: Emmanuel Vadot <manu@FreeBSD.org> > > > > > CommitDate: 2021-03-16 06:12:53 +0000 > > > > > > > > > > include: Remove symlink installation > > > > > > > > > > headers could be installed as symlink to the source tree instead of copies. > > > > > Remove the possibility to do that. > > > > > This make the makefile easier to read and to maintain and also don't duplicate > > > > > code. > > > > > > > > > > While here remove some directories from LSBUDIRS as we already install them using > > > > > the INCS stuff. > > > > > > > > This might make Makefiles easier to read, but also it makes practically > > > > very hard to develop rtld/libc/libthr. After any system header > > > > modification, full buildworld or at least kernel-toolchain run is > > > > required to get buildenv populated with the new headers. > > > > > > Can you share what you did before so I can cook a patch that restore > > > this behavior in a better way than it was done before ? > > > > I did > > $ make buildworld <- this was done relatively irregularly > > $ make buildenv > > [Edit whatever I needed, typically in sys/sys and libexec/rtld-elf] > > <nested env sh>$ cd libexec/rtld-elf > > <nested env sh>$ make DEBUG_FLAGS=-g WITHOUT_TESTS=yes all > > [Check built ld-elf.so.1, more edits] > > <nested env sh>$ make ... > > > > Now, if I modify anything in sys/, I have to repopuate staged headers in > > the obj directory of buildworld. > > Right ok, I've missed that SHARED=symlinks was used in Makefile.inc1, > I'll revert and redo a better patch. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YFBhp6Zd8jUDFjru>