Date: Thu, 24 Feb 2000 01:57:19 -0500 (EST) From: Mike Heffner <mheffner@mailandnews.com> To: Kris Kennaway <kris@FreeBSD.org> Cc: audit@freebsd.org, Alexander Langer <alex@big.endian.de> Subject: RE: hylafax patch (fwd) Message-ID: <XFMail.20000224015719.mheffner@mailandnews.com> In-Reply-To: <Pine.BSF.4.21.0002211531150.33234-200000@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21-Feb-2000 Kris Kennaway wrote: | Does someone have the time to look this over? | | Kris | | ---- | "How many roads must a man walk down, before you call him a man?" | "Eight!" | "That was a rhetorical question!" | "Oh..then, seven!" -- Homer Simpson | | ---------- Forwarded message ---------- | Date: Mon, 21 Feb 2000 15:30:19 +0100 | From: Alexander Langer <alex@big.endian.de> | To: kris@freebsd.org | Subject: hylafax patch | | Hello! | | These should *really* fix it. | | I replaced almost all sprintf and the problematic strcpy/strcat ones. | | Could you review it and maybe add? | Well, I did a quick glance over it. It should really use sizeof() rather than hardcoding the buffer lengths, which could become changed in one location and not another. Also, should it fail if the supplied string is too long for the buffer in some places (ie. supplied command-line args) ? /**************************************** * Mike Heffner <spock@techfour.net> * * Fredericksburg, VA * * ICQ# 882073 * * Sent at: 24-Feb-2000 -- 01:55:57 EST * * http://my.ispchannel.com/~mheffner * ****************************************/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20000224015719.mheffner>