Date: Tue, 09 Jun 2009 17:03:28 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: bzeeb-lists@lists.zabbadoz.net Cc: d@delphij.net, current@FreeBSD.org, hrs@FreeBSD.org, net@FreeBSD.org, rea-fbsd@codelabs.ru Subject: Re: [head tinderbox] failure on sparc64/sparc64 Message-ID: <20090609.170328.129820575.hrs@allbsd.org> In-Reply-To: <20090609074144.O22887@maildrop.int.zabbadoz.net> References: <E1MDvQt-000CEr-B0@kabab.cs.huji.ac.il> <4A2E0D12.40101@delphij.net> <20090609074144.O22887@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Tue_Jun__9_17_03_28_2009_143)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> wrote in <20090609074144.O22887@maildrop.int.zabbadoz.net>: bz> On Tue, 9 Jun 2009, Xin LI wrote: bz> bz> > Danny Braniss wrote: bz> >>> Xin, good day. bz> >>> bz> >>> Mon, Jun 08, 2009 at 04:49:36PM -0700, Xin LI wrote: bz> >>>> The attached patch should fix this, any objections? bz> >>> Yes, you missed negation operator in the copyin check. The issue bz> >>> was already fixed by hrs@ two hours ago: bz> >>> http://svn.freebsd.org/viewvc/base?view=revision&revision=193796 bz> >> sorry to barge in, but: bz> >> if ((options | GIF_FULLOPTS) == GIF_FULLOPTS) bz> >> is not clear, bz> >> if ((options & ~GIF_FULLOPTS) == 0) bz> >> seems to be less offuscated or I'm missing something? bz> > bz> > Yes this looks like the usually used idiom (perhaps more efficient bz> > anyway)... I just kept the style consistent with the old code. bz> > Hiroki-san, could you have a look at this and consider if we should bz> > use bz> > this idiom? bz> bz> Also see the mail I had sent in reply to the commit message yesterday. Sorry, I overlooked some of the messages I received. Yes, the logic was reversed and fixed now, but your patch including style fix looks better to me. I will commit it. Thank you for your review! -- Hiroki ----Security_Multipart(Tue_Jun__9_17_03_28_2009_143)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkouF1AACgkQTyzT2CeTzy1lcACfc5RgQgb7oLMdGSwbMjob4W5M pLkAnRLDVDaLMfpf5e8I2WHV/SeM02Yh =BQGc -----END PGP SIGNATURE----- ----Security_Multipart(Tue_Jun__9_17_03_28_2009_143)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090609.170328.129820575.hrs>