Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Oct 2003 13:22:10 -0800 (PST)
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 40779 for review
Message-ID:  <200310292122.h9TLMA89057278@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=40779

Change 40779 by sam@sam_ebb on 2003/10/29 13:21:44

	avoid recursive lock by unlocking before calling rtrequest;
	this is a bandaid to validate the problem--a proper fix is
	more involved

Affected files ...

.. //depot/projects/netperf/sys/net/route.c#20 edit

Differences ...

==== //depot/projects/netperf/sys/net/route.c#20 (text+ko) ====

@@ -684,11 +684,12 @@
 			 */
 			rt2 = rtalloc1(dst, 0, RTF_PRCLONING);
 			if (rt2 && rt2->rt_parent) {
+				RT_UNLOCK(rt2);		/* XXX recursive lock */
 				rtrequest(RTM_DELETE,
 					  rt_key(rt2),
 					  rt2->rt_gateway,
 					  rt_mask(rt2), rt2->rt_flags, 0);
-				RTFREE_LOCKED(rt2);
+				RTFREE(rt2);
 				rn = rnh->rnh_addaddr(ndst, netmask,
 						      rnh, rt->rt_nodes);
 			} else if (rt2) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200310292122.h9TLMA89057278>