Date: Thu, 8 Aug 2019 11:11:36 -0400 From: Michael Butler <imb@protected-networks.net> To: Renato Botelho <garga@FreeBSD.org>, freebsd-ports@freebsd.org Subject: Re: ports/arj build failing on -current Message-ID: <c092599b-90f7-55ab-df00-34ca083d29e9@protected-networks.net> In-Reply-To: <2a9edfdc-6ae3-b6ae-1096-35e8b36ebdb7@FreeBSD.org> References: <83c4d51e-f137-1533-1a91-4d60ad263744@FreeBSD.org> <b3a9a915-d4e7-e1dd-7694-897e801a8b5b@utanet.at> <2a9edfdc-6ae3-b6ae-1096-35e8b36ebdb7@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-08-08 10:50, Renato Botelho wrote:
> On 08/08/19 11:02, Walter Schwarzenfeld wrote:
>> msgbind.c:452:50: warning: if statement has empty body [-Wempty-body]
>> if(argv[6][strlen(argv[6])-1]!=PATHSEP_DEFAULT);
>> ^
>> msgbind.c:452:50: note: put the semicolon on a separate line to silence
>> this warning
>> 1 warning generated.
>>
>> Do what it want. Try to => put the semicolon on a separate line.
>>
>> (althrough it is a warning, I remember a case, this simple thing "was it").
>
> [resending to the list with proper From]
>
> It looks like that semicolon shouldn't be there.
>
> Michael, can you try attached patch and let me know if it fixes the
> problem? I can't reproduce so it's hard to say.
I will try the patch but, in the interim, I was stepping through it with
lldb and found that it fails a stack check after a few getmsg calls.
(lldb)
Process 5737 stopped
* thread #1, name = 'msgbind', stop reason = instruction step over
frame #0: 0x0000000000203ed8 msgbind`main + 3096
msgbind`main:
-> 0x203ed8 <+3096>: popq %r15
0x203eda <+3098>: popq %rbp
0x203edb <+3099>: retq
0x203edc <+3100>: callq 0x2048a0 ; symbol stub
for: __stack_chk_fail
imb
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c092599b-90f7-55ab-df00-34ca083d29e9>