Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Dec 2018 05:08:57 +0000 (UTC)
From:      Andriy Voskoboinyk <avos@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r342185 - head/sys/dev/iwi
Message-ID:  <201812180508.wBI58vLp057218@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: avos
Date: Tue Dec 18 05:08:56 2018
New Revision: 342185
URL: https://svnweb.freebsd.org/changeset/base/342185

Log:
  iwi(4): do not leak node reference when IWI_FLAG_ASSOCIATED flag is set.
  
  MFC after:	6 days

Modified:
  head/sys/dev/iwi/if_iwi.c

Modified: head/sys/dev/iwi/if_iwi.c
==============================================================================
--- head/sys/dev/iwi/if_iwi.c	Tue Dec 18 03:00:12 2018	(r342184)
+++ head/sys/dev/iwi/if_iwi.c	Tue Dec 18 05:08:56 2018	(r342185)
@@ -2833,12 +2833,12 @@ iwi_auth_and_assoc(struct iwi_softc *sc, struct ieee80
 
 	IWI_LOCK_ASSERT(sc);
 
-	ni = ieee80211_ref_node(vap->iv_bss);
-
 	if (sc->flags & IWI_FLAG_ASSOCIATED) {
 		DPRINTF(("Already associated\n"));
 		return (-1);
 	}
+
+	ni = ieee80211_ref_node(vap->iv_bss);
 
 	IWI_STATE_BEGIN(sc, IWI_FW_ASSOCIATING);
 	error = 0;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812180508.wBI58vLp057218>