Date: Thu, 18 Nov 2010 10:39:53 -0800 From: Rob Farmer <rfarmer@predatorlabs.net> To: Eir Nym <eirnym@gmail.com> Cc: ports@freebsd.org, Jason Helfman <jhelfman@e-e.com> Subject: Re: Mk/bsd.command.mk: missing CSH tag Message-ID: <AANLkTinWsLPV5adAsuFJDnus-TzfUUXFeA6BtgxWbATs@mail.gmail.com> In-Reply-To: <AANLkTindM_EXjD-AdzQ-i0f3T6b9y%2BgxUFOxHOSWL2ph@mail.gmail.com> References: <4CE5280E.3090009@zedat.fu-berlin.de> <AANLkTin5v4NDNQyYDBCJ=r0OUo33vSqLF5a6rYCZQaS2@mail.gmail.com> <20101118160804.GA73849@eggman.experts-exchange.com> <AANLkTimkLmZNVWE1XG4vekHtYYrWWRk9-Jq8shJVdze1@mail.gmail.com> <AANLkTi=N=aG5=swOLjCL0041SZfhq501tE047Rg_H44G@mail.gmail.com> <AANLkTikFzaWcsYgbTTn0PRvK1iK=gzqu=Th8%2BfEXB2R9@mail.gmail.com> <AANLkTinz2PfMOChSbHBvu0MrE_cNR_QkCfPuSnNgbZwg@mail.gmail.com> <AANLkTindM_EXjD-AdzQ-i0f3T6b9y%2BgxUFOxHOSWL2ph@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 18, 2010 at 10:08, Eir Nym <eirnym@gmail.com> wrote:
> On 18 November 2010 21:00, Rob Farmer <rfarmer@predatorlabs.net> wrote:
>> On Thu, Nov 18, 2010 at 09:25, Eir Nym <eirnym@gmail.com> wrote:
>>> Firstly, it is optional part.
>>
>> You didn't answer my question:
>>
>> .if exists(/bin/csh)
>> CSH?=3D =A0 /bin/csh
>> .else
>> CSH?=3D =A0 # What goes here?
>> .endif
>>
> nope, only CSH?=3D /bin/csh without any other checks.
That's exactly what the posted patch does - yet you complained about it:
"Your patch should check if tcsh is in system"
>
> Port should check if ${CSH} is exits in the system.
> And there no replacement in ports tree for this.
>
> And this variable can be in Makefile for port because it is uncommon.
That's a reasonable argument, which is why I suggested Oliver ask here
about if this would be a good idea. Though, personally, I am inclined
to disagree, given some of the other stuff in there.
>
>> And I'm aware it can be dropped using a knob. But I don't think port
>> maintainers should be expected to support anything other than a full
>> base system. This port needs csh, so it will fail if you don't have
>> csh.
>>
>>> and I can rewrite build script to
>>> make(1) or at least shell script
>>
>> Ok, great. But you are still basically saying that certain base system
>> utilities should be off limits because you have chosen to remove them
>> from your system.
>>
>
> If you want, you can remove tcsh(1) from your system using
> WITHOUT_TCSH in src.conf(5) with rebuilding system, and then removing
> obsolete files.
Sure - but this kind of thing isn't really supported - many of the
knobs are rarely used and it is very easy to find stuff that breaks.
--=20
Rob Farmer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinWsLPV5adAsuFJDnus-TzfUUXFeA6BtgxWbATs>