Date: Sun, 12 May 2013 18:39:07 GMT From: Trond Endrestol <trond.endrestol@ximalas.info> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/178540: kern.geom.confdot contains superfluous semicolon at the end of the last curly brace Message-ID: <201305121839.r4CId7Z2002433@oldred.FreeBSD.org> Resent-Message-ID: <201305121840.r4CIe1qS063433@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 178540 >Category: kern >Synopsis: kern.geom.confdot contains superfluous semicolon at the end of the last curly brace >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 12 18:40:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Trond Endrestol >Release: 10.0-CURRENT >Organization: Private >Environment: FreeBSD freebsd10.bsd.net 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r250558: Sun May 12 14:32:16 CEST 2013 root@freebsd10.bsd.net:/usr/obj/usr/src/sys/VBOX amd64 >Description: The sysctl kern.geom.confdot contains a superfluous semicolon after the last curly brace, making the dot utility from graphics/graphviz complain like this: Warning: <stdin>:1: syntax error in line 1 near ';' >How-To-Repeat: Install graphics/graphviz and run: sysctl -n kern.geom.confdot | dot -Tps > geom.ps >Fix: Remove the offending semicolon from sys/geom/geom_dump.c: --- geom_dump.c.orig 2013-04-26 17:16:50.000000000 +0200 +++ geom_dump.c 2013-05-12 20:28:40.369226016 +0200 @@ -105,7 +105,7 @@ sbuf_printf(sb, "digraph geom {\n"); LIST_FOREACH(mp, &g_classes, class) g_confdot_class(sb, mp); - sbuf_printf(sb, "};\n"); + sbuf_printf(sb, "}\n"); sbuf_finish(sb); } Patch attached with submission follows: --- geom_dump.c.orig 2013-04-26 17:16:50.000000000 +0200 +++ geom_dump.c 2013-05-12 20:28:40.369226016 +0200 @@ -105,7 +105,7 @@ sbuf_printf(sb, "digraph geom {\n"); LIST_FOREACH(mp, &g_classes, class) g_confdot_class(sb, mp); - sbuf_printf(sb, "};\n"); + sbuf_printf(sb, "}\n"); sbuf_finish(sb); } >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305121839.r4CId7Z2002433>