Date: Tue, 20 Jun 2006 17:07:04 -0400 From: John Baldwin <jhb@freebsd.org> To: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua> Cc: kan@freebsd.org, Adi Pircalabu <apircalabu@bitdefender.com>, freebsd-current@freebsd.org, Hajimu UMEMOTO <ume@freebsd.org>, Ivan Voras <ivoras@fer.hr> Subject: Re: Linux-flashplugin7 & rtld - RFC Message-ID: <200606201707.05938.jhb@freebsd.org> In-Reply-To: <20060620230149.S43840@atlantis.atlantis.dp.ua> References: <449015DE.6090407@fer.hr> <200606201002.07695.jhb@freebsd.org> <20060620230149.S43840@atlantis.atlantis.dp.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 20 June 2006 16:07, Dmitry Pryanishnikov wrote: > > Hello! > > On Tue, 20 Jun 2006, John Baldwin wrote: > >>> This patch is somewhat redundant. Adding > >>> > >>> __weak_reference(dlsym, _dlsym); > >>> > >>> is enough. > >> > >> Indeed, this also works for me. It would be nice to see this trivial > >> addition committed. > > > > I agree. Do you have the __weak_reference() patch handy? > > Sure, here is the diff against HEAD: > > --- libexec/rtld-elf/rtld.c.orig Tue Mar 28 10:17:21 2006 > +++ libexec/rtld-elf/rtld.c Tue Jun 20 22:35:17 2006 > @@ -137,6 +137,8 @@ > > void r_debug_state(struct r_debug*, struct link_map*); > > +__weak_reference(dlsym, _dlsym); > + > /* > * Data declarations. > */ > > I'm not sure whether it's style(9)-compliant, it just works. Well, this patch was shot down. Would it be possible to have the pluginwrapper provide the _dlsym weak reference itself? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606201707.05938.jhb>