Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 Nov 2007 18:14:26 +0200
From:      Peter Pentchev <roam@ringlet.net>
To:        Martin Wilke <miwi@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, Dmitry Marakasov <amdmi3@amdmi3.ru>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/games/mirrormagic Makefile ports/games/mirrormagic/files patch-src-main.h
Message-ID:  <20071106161426.GA91640@straylight.m.ringlet.net>
In-Reply-To: <200711051120.lA5BK1M1068240@repoman.freebsd.org>
References:  <200711051120.lA5BK1M1068240@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--C7zPtVaVf+AK4Oqc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 05, 2007 at 11:20:01AM +0000, Martin Wilke wrote:
> miwi        2007-11-05 11:20:01 UTC
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     games/mirrormagic    Makefile=20
>   Added files:
>     games/mirrormagic/files patch-src-main.h=20
>   Log:
>   - Fix build with gcc 4.2
>   - Pass maintainership to submitter
>  =20
>   PR:             117731
>   Submitted by:   Dmitry Marakasov <amdmi3@amdmi3.ru>
>   Approved by:    portmgr (pav)

Rrrrriiiiight, and this happens just when I was looking at the mirrormagic
port and have a couple of patches coming up :)  Still, they would be left
for after the freeze anyway, so I guess I'll coordinate them with Dmitry
afterwards - thanks for taking care of the build problem!

But... don't we want to bump PORTREVISION here?  The commit added an SDL
OPTION (which I'd also done privately) *and then changed it to default on*
which changes the build behavior - the new binary package will have way
more dependencies and way more functionality than until now.  So, should
PORTREVISION not be bumped?

G'luck,
Peter

--=20
Peter Pentchev	roam@ringlet.net    roam@cnsys.bg    roam@FreeBSD.org
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
You have, of course, just begun reading the sentence that you have just fin=
ished reading.

--C7zPtVaVf+AK4Oqc
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)

iD8DBQFHMJLi7Ri2jRYZRVMRAvsLAKDENsImfX/xZnp/QiBc3csrrJelWACfXChV
b2tsxWa4VEATCt7W/zKhUpo=
=eOw3
-----END PGP SIGNATURE-----

--C7zPtVaVf+AK4Oqc--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071106161426.GA91640>