Date: Fri, 25 Apr 2014 11:20:12 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r352093 - head/x11/startup-notification Message-ID: <20140425092011.GB38988@ivaldir.etoilebsd.net> In-Reply-To: <20140425111327.3e351b84@kalimero.tijl.coosemans.org> References: <201404250738.s3P7c2CV097634@svn.freebsd.org> <20140425111327.3e351b84@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--l76fUT7nc3MelDdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 25, 2014 at 11:13:27AM +0200, Tijl Coosemans wrote: > On Fri, 25 Apr 2014 07:38:02 +0000 (UTC) Baptiste Daroussin wrote: > > Author: bapt > > Date: Fri Apr 25 07:38:01 2014 > > New Revision: 352093 > > URL: http://svnweb.freebsd.org/changeset/ports/352093 > > QAT: https://qat.redports.org/buildarchive/r352093/ > >=20 > > Log: > > Switch to USES=3Dlibtool > > Strip binaries > >=20 > > Modified: > > head/x11/startup-notification/Makefile > > head/x11/startup-notification/pkg-plist > >=20 > > Modified: head/x11/startup-notification/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/x11/startup-notification/Makefile Fri Apr 25 07:34:14 2014 (r3= 52092) > > +++ head/x11/startup-notification/Makefile Fri Apr 25 07:38:01 2014 (r3= 52093) > > @@ -4,7 +4,7 @@ > > =20 > > PORTNAME=3D startup-notification > > PORTVERSION=3D 0.12 > > -PORTREVISION=3D 1 > > +PORTREVISION=3D 2 > > CATEGORIES=3D x11 gnome > > MASTER_SITES=3D http://www.freedesktop.org/software/startup-notificati= on/releases/ > > DIST_SUBDIR=3D gnome2 > > @@ -12,16 +12,15 @@ DIST_SUBDIR=3D gnome2 > > MAINTAINER=3D gnome@FreeBSD.org > > COMMENT=3D Library that supports startup notification spec from freede= sktop.org > > =20 > > -LIB_DEPENDS=3D xcb-util:${PORTSDIR}/x11/xcb-util > > +LIB_DEPENDS=3D libxcb-util.so:${PORTSDIR}/x11/xcb-util > > =20 > > USE_XORG=3D x11 > > -USE_AUTOTOOLS=3D libtool > > -USES=3D gmake pathfix pkgconfig > > -USE_GNOME=3D ltasneededhack > > +USES=3D gmake libtool pathfix pkgconfig > > GNU_CONFIGURE=3D yes > > USE_LDCONFIG=3D yes > > CPPFLAGS+=3D -I${LOCALBASE}/include > > LDFLAGS+=3D -L${LOCALBASE}/lib > > CONFIGURE_ARGS+=3Dac_cv_lib_ICE_IceConnectionNumber=3Dno > > +INSTALL_TARGET=3D install-strip > > =20 > > .include <bsd.port.mk> > >=20 > > Modified: head/x11/startup-notification/pkg-plist > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/x11/startup-notification/pkg-plist Fri Apr 25 07:34:14 2014 (r= 352092) > > +++ head/x11/startup-notification/pkg-plist Fri Apr 25 07:38:01 2014 (r= 352093) > > @@ -5,9 +5,9 @@ include/startup-notification-1.0/libsn/s > > include/startup-notification-1.0/libsn/sn-util.h > > include/startup-notification-1.0/libsn/sn.h > > lib/libstartup-notification-1.a > > -lib/libstartup-notification-1.la > > lib/libstartup-notification-1.so > > lib/libstartup-notification-1.so.0 > > +lib/libstartup-notification-1.so.0.0.0 > > libdata/pkgconfig/libstartup-notification-1.0.pc > > @dirrm include/startup-notification-1.0/libsn > > @dirrm include/startup-notification-1.0 >=20 > It's probably better to use libtool:keepla here. There are too many > ports that depend on this port with .la files that may refer to > libstartup-notification-1.la. >=20 > I've been thinking if it would be possible for pkg to register .la files > (and their references to other libraries) like it does with .so files. > Then you could find out if there are references lurking in other ports > with pkg rquery. >=20 Concerning gnome related ports like this one I'm pretty confident about rem= oving the .la as upstream jhbuild continuous integration system expect everything= to be install without .la, so almost nothing should expect to find the .la her= e. concerning registering the .la that will be quite complicated because as fa= r as I know, no trace of .la is left inside the resulted binaries, but if you th= ink about a clever way, I'm not against it :) regards, Bapt --l76fUT7nc3MelDdI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlNaKMsACgkQ8kTtMUmk6EwM5gCfY0oBjJiaXmro89oow8IbmbXr EzcAn1lS8Sv6u99qVWKglLObyuAMYpW9 =Zcu2 -----END PGP SIGNATURE----- --l76fUT7nc3MelDdI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140425092011.GB38988>