Date: Tue, 20 Jun 2000 15:02:47 -0600 From: Wes Peters <wes@softweyr.com> To: Dag-Erling Smorgrav <des@flood.ping.uio.no> Cc: "Jordan K. Hubbard" <jkh@zippy.osd.bsdi.com>, Wes Peters <wes@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch ftp.c Message-ID: <394FDBF7.68C505BD@softweyr.com> References: <6113.961509871@localhost> <xzpn1kgs01v.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smorgrav wrote: > > "Jordan K. Hubbard" <jkh@zippy.osd.bsdi.com> writes: > > > Wes Peters <wes@FreeBSD.org> writes: > > > > Log: > > > > Add implementation of fetchListFTP. > > > Absolutely not acceptable under any pretext. > > You should also say why. It does not foster good relations between > > developers when you simply back something out without previous comment > > or any explanation as to why it's not acceptable. > > 1) I am the maintainer of this code, and the README clearly states > that although contributions are welcome, no commits should be made > without my prior agreement. > > 2) The patch is unnecessarily bulky and duplicates code found > elsewhere in libfetch. I chose to set it aside until I was finished > rewriting the HTTP code, which already suffers severely from code > duplication. Such an answer would have been nice to hear, and would have spared us this little tango. I believe "being responsive to requests for reviews" was one of those golden rules we all had so much fun dicussing just a few short months ago, wasn't it? -- "Where am I, and what am I doing in this handbasket?" Wes Peters Softweyr LLC wes@softweyr.com http://softweyr.com/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?394FDBF7.68C505BD>