Date: Fri, 14 Nov 2003 12:23:54 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org Subject: RE: cvs commit: src/sys/conf kern.post.mk kmod.mk Message-ID: <Pine.NEB.3.96L.1031114122317.18149C-100000@fledge.watson.org> In-Reply-To: <XFMail.20031114113017.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 14 Nov 2003, John Baldwin wrote: > On 14-Nov-2003 Brian Feldman wrote: > > green 2003/11/14 08:04:11 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/conf kern.post.mk kmod.mk > > Log: > > Include opt_global.h in the modules build, when building from a normal > > kernel build. This makes it possible for me not to get pissed off that > > random.ko crashes the system trying to rdtsc() when the i386/cpu.h > > support code decides it's okay to call that op when neither I386_CPU or > > I486_CPU is defined. I guess it also makes WITNESS/INVARIANTS defines > > get picked up by the modules. > > WITNESS doesn't matter as all calls to it are done in the actual locking > code itself which does not lives in modules. Modules always call the > locking functions and don't inline locking operations. I'd have picked up the syntax error in mac_test.c if this had been in place then :-). And it makes mac_test and other regression test modules far more functional... Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1031114122317.18149C-100000>