Date: Sun, 13 Oct 2019 08:27:28 +0200 From: Tobias Kortkamp <tobik@freebsd.org> To: Rodrigo Osorio <rodrigo@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r514349 - in head/sysutils: . sanoid sanoid-devel Message-ID: <20191013062728.GC89782@urd.tobik.me> In-Reply-To: <201910121812.x9CICaTk096146@repo.freebsd.org> References: <201910121812.x9CICaTk096146@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 12, 2019 at 06:12:36PM +0000, Rodrigo Osorio wrote: > Author: rodrigo > Date: Sat Oct 12 18:12:36 2019 > New Revision: 514349 > URL: https://svnweb.freebsd.org/changeset/ports/514349 >=20 > Log: > New ports sysutils/sanoid and sysutils/sanoid-devel > =20 > Sanoid is a policy-driven snapshot management tool > for ZFS filesystems. You can use Sanoid to create, > automatically and monitor snapshots. > =20 > Add sysutils/sanoid-devel to track interesting > moments on the master branch. > =20 > PR: 238584 > Submitted by: <hartzell@alerce.com> > > Added: head/sysutils/sanoid-devel/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/sanoid-devel/Makefile Sat Oct 12 18:12:36 2019 (r514349) > @@ -0,0 +1,51 @@ > +# $FreeBSD$ > + > +PORTNAME=3D sanoid > +PORTVERSION=3D1.0.0.20190619 > +CATEGORIES=3D sysutils > +PKGNAMESUFFIX=3D-devel > + > +MAINTAINER=3D hartzell@alerce.com > +COMMENT=3D Policy-driven snapshot management and replication tools > + > +LICENSE=3D GPLv3 > +LICENSE_FILE=3D ${WRKSRC}/LICENSE > + > +RUN_DEPENDS=3D ${LOCALBASE}/bin/lzop:archivers/lzop \ > + ${LOCALBASE}/bin/mbuffer:misc/mbuffer \ > + ${LOCALBASE}/bin/pv:sysutils/pv \ > + p5-Capture-Tiny>=3D0:devel/p5-Capture-Tiny \ > + p5-Config-IniFiles>=3D0:devel/p5-Config-IniFiles > + > +USES=3D shebangfix perl5 > + > +USE_GITHUB=3D yes > +GH_ACCOUNT=3D jimsalterjrs > +GH_PROJECT=3Dsanoid Redundant. GH_PROJECT is set to ${PORTNAME} by default. > +GH_TAGNAME=3Da90eec3 > + > +USE_PERL5=3D run > +SHEBANG_FILES=3D findoid sanoid sleepymutex syncoid > + > +# line 19: my %args =3D ("configdir" =3D> "/etc/sanoid"); > +post-patch: > + @${REINPLACE_CMD} -i '' -e 's|/etc/sanoid|${PREFIX}/etc/sanoid|' \ > + ${WRKSRC}/sanoid > + @${REINPLACE_CMD} -i '' \ > + -e 's|:/bin:/usr/bin:/sbin|:${PREFIX}/bin:/bin:/usr/bin:/sbin|' \ > + ${WRKSRC}/syncoid > + > +do-build: If the port does not build anything this should be NO_BUILD=3D yes =46rom the looks of it, we could probably also add NO_ARCH=3D yes > + > +do-install: > + ${INSTALL_SCRIPT} ${WRKSRC}/findoid ${STAGEDIR}${PREFIX}/bin > + ${INSTALL_SCRIPT} ${WRKSRC}/sanoid ${STAGEDIR}${PREFIX}/bin > + ${INSTALL_SCRIPT} ${WRKSRC}/sleepymutex ${STAGEDIR}${PREFIX}/bin > + ${INSTALL_SCRIPT} ${WRKSRC}/syncoid ${STAGEDIR}${PREFIX}/bin > + @${MKDIR} ${STAGEDIR}/${ETCDIR} > + ${INSTALL_DATA} ${WRKSRC}/sanoid.defaults.conf \ > + ${STAGEDIR}${ETCDIR}/sanoid.defaults.conf > + ${INSTALL_DATA} ${WRKSRC}/sanoid.conf \ > + ${STAGEDIR}${ETCDIR}/sanoid.conf.sample > + > +.include <bsd.port.mk> >=20 > Added: head/sysutils/sanoid-devel/distinfo > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/sanoid-devel/distinfo Sat Oct 12 18:12:36 2019 (r514349) > @@ -0,0 +1,3 @@ > +TIMESTAMP =3D 1560978182 > +SHA256 (jimsalterjrs-sanoid-1.0.0.20190619-a90eec3_GH0.tar.gz) =3D 32fe6= ef68735e074f8c11d28e06d4e4d9f35cde7b80bacb20636f0fb1fb45500 > +SIZE (jimsalterjrs-sanoid-1.0.0.20190619-a90eec3_GH0.tar.gz) =3D 113654 >=20 > Added: head/sysutils/sanoid-devel/pkg-descr > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/sanoid-devel/pkg-descr Sat Oct 12 18:12:36 2019 (r51434= 9) > @@ -0,0 +1,4 @@ > +Sanoid is a policy-driven snapshot management tool for ZFS > +filesystems. More prosaically, you can use Sanoid to create, > +automatically thin, and monitor snapshots and pool health from a > +single eminently human-readable TOML config file. Missing WWW here. >=20 > Added: head/sysutils/sanoid-devel/pkg-message > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/sanoid-devel/pkg-message Sat Oct 12 18:12:36 2019 (r514= 349) > @@ -0,0 +1,28 @@ > +[ > +{ > + message: <<EOD > +************************************************************************= *** > + > + Sanoid requires additional configuration in the ${PREFIX}/etc/sanoid.co= nf=20 > + file. > + > + A sample has been installed in ${PREFIX}/etc/sanoid.conf.sample and Wrong path to sanoid.conf. It is installed under /usr/local/etc/sanoid/sanoid.conf. > + additional documentation can be found at the sanoid master site: > +=20 > + https://github.com/jimsalterjrs/sanoid The homepage should be in pkg-descr too. > + > +************************************************************************= *** > +EOD > +} > +{ > + message: <<EOD > +************************************************************************= *** > + > + If you have created a local configuration file, > + ${PREFIX}/etc/sanoid.conf, you will need to remove it separately. > + > +************************************************************************= *** > +EOD > + type: remove > +} > +] Redundant. @sample already prints a message like this on deinstall but only when sanoid.conf has been modified. Please remove the noisy '****' banners. They do not add anything of value. > Added: head/sysutils/sanoid/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/sysutils/sanoid/Makefile Sat Oct 12 18:12:36 2019 (r514349) > @@ -0,0 +1,51 @@ > +# $FreeBSD$ > + > +PORTNAME=3D sanoid > +DISTVERSION=3D v2.0.1 > +CATEGORIES=3D sysutils Should probably be DISTVERSIONPREFIX=3D v DISTVERSION=3D 2.0.1 > +post-patch: > [...] > + @${REINPLACE_CMD} -i '' \ > + -e 's|/usr/bin/lzop|${PREFIX}/bin/lzop|' \ > + -e 's|/usr/bin/mbuffer|${PREFIX}/bin/mbuffer|' \ > + -e 's|/usr/bin/pv|${PREFIX}/bin/pv|' \ > + -e 's|/usr/bin/sudo|${PREFIX}/bin/sudo|' \ > + ${WRKSRC}/syncoid Dependencies come from LOCALBASE, so this should use LOCALBASE not PREFIX. Most of the items from sanoid-devel also apply to sanoid. --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl2iw9BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2EZNgf+PDElgEOgp8yG82ll4svtk5KKT5Nfe0TEu4vu6fbAEMCeUcgXcOZ6f+FS j/zddTH3DsXaYdSEf27R7KPFiScvBewiUxWTBiQCbifuFI0YaeU9HINFaYaW9k1W uud88ZmOr/mKtg1mC5jQVw0PnR1AFUOIK6/kGuRezBM0m4ef5UkfArh69dfui4T5 YtG0FYmpLOq7FtFPuHTbfQv16oUWsOK7aY6a6z8O6ZXdPzj7dfycCL+gYg6vUBoW WVHrwnI4cQRVHK9LoJ1jokzjinhvaPeQ1wQLTUCEfavY6f3VcgRmI0CLeLYJBARc nbDwShDLNcAGBIzIoimIVa6VPhdiHw== =nmQ0 -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191013062728.GC89782>