Date: Mon, 3 Dec 2007 16:57:33 -0500 From: John Baldwin <jhb@freebsd.org> To: Dag-Erling =?utf-8?q?Sm=C3=B8rgrav?= <des@des.no> Cc: cvs-src@freebsd.org, John Birrell <jb@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet/libalias alias_util.c Message-ID: <200712031657.34074.jhb@freebsd.org> In-Reply-To: <864pezer7f.fsf@ds4.des.no> References: <200711232356.lANNu3mp040885@repoman.freebsd.org> <864pezer7f.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 03 December 2007 10:24:52 am Dag-Erling Sm=C3=B8rgrav wrote: > John Birrell <jb@FreeBSD.org> writes: > > Log: > > Fix strict alias warnings. >=20 > A much simpler solution (relative to the previous revision): >=20 > @@ -131,10 +131,10 @@ > sum +=3D oddbyte; > } > /* "Pseudo-header" data */ > - ptr =3D (u_short *) & (pip->ip_dst); > + ptr =3D (void *)&pip->ip_dst; > sum +=3D *ptr++; > sum +=3D *ptr; > - ptr =3D (u_short *) & (pip->ip_src); > + ptr =3D (void *)&pip->ip_src; > sum +=3D *ptr++; > sum +=3D *ptr; > sum +=3D htons((u_short) ntcp); *ptr++ would choke since pointer arith on (void *) is undefined AFAIK. =2D-=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712031657.34074.jhb>