Date: Mon, 12 Dec 2016 20:12:57 +0100 From: Edward Tomasz Napierala <trasz@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309891 - head/sys/kern Message-ID: <20161212191257.GA11238@brick> In-Reply-To: <20161212163331.GH54029@kib.kiev.ua> References: <201612121522.uBCFMMmm088698@repo.freebsd.org> <20161212163331.GH54029@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1212T1833, Konstantin Belousov wrote: > On Mon, Dec 12, 2016 at 03:22:22PM +0000, Edward Tomasz Napierala wrote: > > Author: trasz > > Date: Mon Dec 12 15:22:21 2016 > > New Revision: 309891 > > URL: https://svnweb.freebsd.org/changeset/base/309891 > > > > Log: > > Avoid dereferencing NULL pointers in devtoname(). I've seen it panic, > > called from ufs_print() in DDB. > Calls from DDB should not panic even if accessing NULL pointers. Yeah, by "panic" I've meant the "reentering ddb" thing. It's not a panic per se, but still breaks eg "show lockedvnodes". > That said, I also do not think that this is the right place to change. > UFS um_dev should not be NULL for any active mount. After looking at this once again I agree. Looks like some kind of bug specific to my sources at that point of time. Backed off.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161212191257.GA11238>