Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 12 Jan 1995 10:32:10 -0500 (EST)
From:      Wankle Rotary Engine <wpaul@skynet.ctr.columbia.edu>
To:        freebsd-hackers@FreeBSD.org
Subject:   Small syscons change
Message-ID:  <199501121532.KAA02843@skynet.ctr.columbia.edu>

next in thread | raw e-mail | index | archive | help
After some discussion with Bruce Evans, I've decided to submit the following
tiny patch for /sys/i386/isa/syscons.c:

*** syscons.c.orig	Thu Jan 12 09:52:45 1995
--- syscons.c	Thu Jan 12 09:53:13 1995
***************
*** 2100,2110 ****
  		/* Print only printables */
  		*scp->crtat = (scp->term.cur_attr | scr_map[c]);
  		scp->crtat++;
! 		/*
! 		 * Wrap at the *LAST* column, not the last column
! 		 * minus one!!!! Arrrghhh!!!
! 		 */
! 		if (++scp->xpos > /* = */ scp->xsize) {
  			scp->xpos = 0;
  			scp->ypos++;
  		}
--- 2100,2106 ----
  		/* Print only printables */
  		*scp->crtat = (scp->term.cur_attr | scr_map[c]);
  		scp->crtat++;
! 		if (++scp->xpos >=  scp->xsize) {
  			scp->xpos = 0;
  			scp->ypos++;
  		}


This patch backs out the 'cursor wraps at wrong place' fix I had bundled
in with my NOBLINK_CURSOR mods. Apparently this change breaks elvis and
bash (although bash's problems appear to be bash's own fault -- this is
version 1.14.2 we're talking about here). The NOBLINK_CURSOR mods don't
seem to be a problem. (They better not be. :)

I made this change originally to avoid some trouble I was having with a VAX
that steadfastly insisted on wrapping at the wrong place when using ANSI
terminal mode (SET TERM/DEV=UNKNOWN/ANSI). I guess what's good for the VAX
isn't good for everyone else.

If anyone else has noticed problems with this, please speak up.

-Bill

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~T~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-Bill Paul            (212) 854-6020 | System Manager
Work:         wpaul@ctr.columbia.edu | Center for Telecommunications Research
Home:  wpaul@skynet.ctr.columbia.edu | Columbia University, New York City
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The Møøse Illuminati: ignore it and be confused, or join it and be confusing!
~~~~~~~~ FreeBSD 2.1.0-Development #0: Mon Jan  9 14:59:33 EST 1995 ~~~~~~~~~



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199501121532.KAA02843>