Date: Fri, 22 Mar 2013 10:21:12 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, Boris Samorodov <bsam@passap.ru>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r314859 - head/palm/jpilot Message-ID: <514C76E8.2070206@FreeBSD.org> In-Reply-To: <20130322151200.GA14206@ithaqua.etoilebsd.net> References: <201303211827.r2LIRHrh078301@svn.freebsd.org> <514C6DEF.10201@passap.ru> <20130322145344.GA16844@FreeBSD.org> <20130322151200.GA14206@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2CRUWWBTVCFLMCPIKFBSV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 3/22/2013 10:12 AM, Baptiste Daroussin wrote: > On Fri, Mar 22, 2013 at 02:53:44PM +0000, Alexey Dokuchaev wrote: >> On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote: >>> 21.03.2013 22:27, Baptiste Daroussin =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> --- head/palm/jpilot/Makefile Thu Mar 21 18:25:04 2013 (r314858) >>>> +++ head/palm/jpilot/Makefile Thu Mar 21 18:27:17 2013 (r314859) >>> [...] >>>> -# "?=3D" and "+=3D" are for including this Makefile from japanese/j= pilot >>> >>> Not particular to this commit, but rather a general question: >>> what is our current policy on comments at the makefile headers? >>> I mean non-standard comments (maintainer tips, etc.). Should >>> they be deleted? >> >> I would not delete them (in general case). In this particular case I = assume >> they were deleted because they were stating quite obvious thing: certa= in >> variables with +=3D/?=3D are clear indication of master/slave relation= ship. >> >> ./danfe >=20 > Deleting was a mistake, I will readd them once I'm back on a box where = I can > commit on the ports tree. >=20 > Meaning probably monday. >=20 > Except if somone wants to do it now, he gets my approval. >=20 > regards, > Bapt >=20 Fixed --=20 Regards, Bryan Drewery bdrewery@freenode/EFNet ------enig2CRUWWBTVCFLMCPIKFBSV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRTHboAAoJEG54KsA8mwz5KB8P/iPIsKVLYKqhjTmHulQhNzQk se1oQ3VB4I547pGmVq8e2gpf86FkAgvPtX1QvioF5bSk8gboK9yEHvoTvUfHsH47 FH3vvVCa91HptFOLtpeOXhwEvPfXVKbfKnyy5q5N4NvsCxlShc+a35LWSnn3/dTB XGi/fBYw+L0AshnQZ15r92/SLPQZTZwhEsU7Xod505na+Mq3E4eAMZABpS9d+Nx6 Ug8LRY1gYrEUYuK0moDP9FCuZ8r0RStZpGxnnTVWQBwpEOT1jCWl6RvH+vNtndzw 0AzjBZlF+mW1OpaH0EKUylM7pubLvlEDJNFy+MsBN0+Umh3OvN8X7ehBnYSQOAfB 8Eq9q9wy07rYQRA0UYQDp3WM+gwyJpSLRVg6yjhQscbyKRAOGSXu8wAQ1T4XbpGc QcBkVdVAiJGoI3pRNYeRq9qelhUlFiAbA9dlf/24MPq9ZAJY7/fl0tXs5tD8Mgvb d6t45PfjRZTvZVY/fkYA6SiDPCS9yfaesNJNl5PgC5uk32qHUB1RhUZyY1oMP4vX x4c5gihnHQNwT2eKzU7bFeQJWCWBESdJdAPp8nnRna6V/SLubX06UeAPT6yxFNNM VoHwjH5qH9y0mZkvpHcgbT8Rz+hEHHwg/9Baio1w4csDuQ+OqjZnDSYcL+QeKCtZ qgYJWVqfYarMEsTAJ4Co =rUG4 -----END PGP SIGNATURE----- ------enig2CRUWWBTVCFLMCPIKFBSV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?514C76E8.2070206>