Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Mar 2013 17:47:25 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Koop Mast <kwm@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r314380 - head/graphics/colord
Message-ID:  <20130316174725.GA67587@FreeBSD.org>
In-Reply-To: <201303161736.r2GHas76043600@svn.freebsd.org>
References:  <201303161736.r2GHas76043600@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 16, 2013 at 05:36:54PM +0000, Koop Mast wrote:
> New Revision: 314380
> URL: http://svnweb.freebsd.org/changeset/ports/314380
> 
> Log:
>   Prevert ! instead of empty() and fix a typo.

It seems you've fixed typo in original submission, not in the Makefile. :)
Could be confusing.

> @@ -57,7 +57,7 @@ post-patch:
>  		-e 's|-Wmissing-parameter-type||g' \
>  		-e 's|LIBS="-lusb-1.0|LIBS="-lusb|g' \
>  		${WRKSRC}/configure
> -.if empty(PORT_OPTIONS:MMANPAGES}
> +.if !${PORT_OPTIONS:MMANPAGES}

It's usually better to pad ! with a space after it, helps to stand out.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130316174725.GA67587>