Date: Wed, 6 Oct 1999 15:40:01 -0700 (PDT) From: Ruslan Ermilov <ru@FreeBSD.ORG> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/14170: ppp(8) no more detects carrier lost Message-ID: <199910062240.PAA66920@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/14170; it has been noted by GNATS. From: Ruslan Ermilov <ru@FreeBSD.ORG> To: FreeBSD-gnats-submit@FreeBSD.ORG Cc: Subject: Re: bin/14170: ppp(8) no more detects carrier lost Date: Thu, 7 Oct 1999 01:35:48 +0300 On Thu, Oct 07, 1999 at 12:35:50AM +0300, ru@FreeBSD.ORG wrote: > > When either remote or local end drops a connection ungracefully, > e.g. by simply turning off the modem, ppp(8) does not detect the > carrier lost and continues occupy the link. Consequences are > obvious. No further logins could be made on this link, since > getty will not get control over this line. > Just to help Brian find the problem: The following version still detects carrier: # cd /usr/src/usr.sbin/ppp; cvs upd -D"08/06/1999 13:00:00 PDT" -P -d But the following (and further) do not: # cd /usr/src/usr.sbin/ppp; cvs upd -D"08/06/1999 13:05:00 PDT" -P -d So, the problem raised somewhere in the following commit: :brian 1999/08/06 13:04:09 PDT : : Modified files: : usr.sbin/ppp Makefile README.changes bundle.c ccp.c : datalink.c datalink.h deflate.c exec.c : hdlc.c ip.c link.c pap.c physical.c : physical.h ppp.8 tcp.c tty.c tun.c udp.c : vjcomp.c : Added files: : usr.sbin/ppp i4b.c i4b.h : Log: : Add ISDN support via isdnd & i4b. This requires version : 0.81.1 of the i4b code - namely support of the I4B_VR_REQ : ioctl via the i4brbchX device. : : Ppp controls the phone number, but idle timers and : SYNC/RAW decisions are still made by isdnd (in isdnd.rc). : : This involves a new datalink state machine phase. The : ``wait for carrier'' phase happens after dialing but : before logging in. The whole dial state should really : be abstracted so that each device type can deal with it : in its own way (thinking about PPPoE) - but that'll have : to wait. : : The ``set cd'' symantics remain the same for tty devices, : but we now delay until we either get CD or timeout waiting : (at which time we drop the link if we require CD). : : For i4b devices we always insist on carrier. : : Thanks to hm@ for his help, and especially for pointing out : that I *don't* need to re-implement isdnd (that was a huge : waste of time !) :-] : : Revision Changes Path : 1.56 +8 -2 src/usr.sbin/ppp/Makefile : 1.12 +2 -0 src/usr.sbin/ppp/README.changes : 1.60 +2 -3 src/usr.sbin/ppp/bundle.c : 1.51 +2 -2 src/usr.sbin/ppp/ccp.c : 1.43 +27 -6 src/usr.sbin/ppp/datalink.c : 1.8 +9 -7 src/usr.sbin/ppp/datalink.h : 1.15 +1 -3 src/usr.sbin/ppp/deflate.c : 1.7 +2 -16 src/usr.sbin/ppp/exec.c : 1.44 +1 -16 src/usr.sbin/ppp/hdlc.c : 1.68 +1 -3 src/usr.sbin/ppp/ip.c : 1.13 +1 -2 src/usr.sbin/ppp/link.c : 1.37 +2 -2 src/usr.sbin/ppp/pap.c : 1.20 +16 -5 src/usr.sbin/ppp/physical.c : 1.14 +14 -5 src/usr.sbin/ppp/physical.h : 1.188 +41 -10 src/usr.sbin/ppp/ppp.8 : 1.5 +2 -2 src/usr.sbin/ppp/tcp.c : 1.10 +63 -76 src/usr.sbin/ppp/tty.c : 1.16 +3 -1 src/usr.sbin/ppp/tun.c : 1.4 +2 -2 src/usr.sbin/ppp/udp.c : 1.32 +2 -2 src/usr.sbin/ppp/vjcomp.c -- Ruslan Ermilov Sysadmin and DBA of the ru@ucb.crimea.ua United Commercial Bank, ru@FreeBSD.org FreeBSD committer, +380.652.247.647 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199910062240.PAA66920>