Date: Fri, 23 Nov 2012 08:51:43 +0100 From: Andre Oppermann <andre@freebsd.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Ermal Lu?i <eri@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-user@FreeBSD.org Subject: Re: svn commit: r243414 - user/andre/tcp_workqueue/sys/net Message-ID: <50AF2B0F.7000002@freebsd.org> In-Reply-To: <20121123064413.GG84121@FreeBSD.org> References: <201211222043.qAMKh9Zs060179@svn.freebsd.org> <CAPBZQG1kYUNBhX5=P=Ja9rPuT45rizXP6sq%2BZP0fv13mD7nJUw@mail.gmail.com> <50AEA39D.4080704@freebsd.org> <CAPBZQG2O4hdLM6mKGQo75Eo-oDo%2BriG9Q%2BM7TjY2zJVmBnYfLA@mail.gmail.com> <50AEB2CF.3040904@freebsd.org> <20121123064413.GG84121@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 23.11.2012 07:44, Gleb Smirnoff wrote: > On Fri, Nov 23, 2012 at 12:18:39AM +0100, Andre Oppermann wrote: > A> > On Thu, Nov 22, 2012 at 11:13 PM, Andre Oppermann <andre@freebsd.org <mailto:andre@freebsd.org>> wrote: > A> > > A> > Hello Andre, > A> > you plan to introduce pfil(9) at layer2 as well? > A> > > A> > We already have that in net/if_ethersubr.c for ethernet at least. > A> > > A> > Hmm have missed the addition of that one. > A> > I would have liked that with that hook all the special cases(bridge/netgraph/carp/... to go away. > A> > A> Indeed. Lets make it happen. :-) > > It is impossible to convert netgraph to be a pfil, since netgraph isn't > just a function call. It doesn't return processed packet immediately. That's why I added the pfil cookies. You can re-inject a packet after a particular hook after deferred processing. > The carp(4) isn't a layer 2 protocol, but is IP protocol, so I > don't understand how can it be converted to a pfil hook. Obviously not everything can be a layer 2 pfil hook. Where it can, we should at least investigate it to limit the number of special cases in the path. A potential issue is the cpu pinning of the pfil rmlock. We'll have to see whether this is an immediate problem, and if yes, what we can do about it. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50AF2B0F.7000002>