Date: Thu, 30 Sep 2021 21:50:21 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Piotr Kubaj <pkubaj@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: fc75da3a3b2a - main - graphics/libjxl: fix build on powerpc64* Message-ID: <y27d-6dxe-wny@FreeBSD.org> In-Reply-To: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org> (Piotr Kubaj's message of "Thu, 30 Sep 2021 15:50:50 GMT") References: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Piotr Kubaj <pkubaj@FreeBSD.org> writes: > The include in cpu.cc is not actually necessary, so I did not include anything for FreeBSD. [...] > +--- tools/cpu/cpu.cc.orig 2021-09-30 15:38:45 UTC > ++++ tools/cpu/cpu.cc > +@@ -19,7 +19,9 @@ > + #endif > + > + #if JXL_ARCH_PPC > +-#include <sys/platform/ppc.h> // __ppc_get_timebase_freq > ++#if linux > ++#include <sys/platform/ppc.h> // NOLINT __ppc_get_timebase_freq > ++#endif > + #endif Can you file a bug via https://github.com/libjxl/libjxl/issues/new ? That include is probably unused even on Linux after 5175d11717f3 removed __ppc_get_timebase_freq. Note, if you can't sign Google CLA don't submit a fix. Otherwise, upstream will refuse to read the rationale (PR description), let alone the patch e.g., https://github.com/libjxl/libjxl/pull/193
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?y27d-6dxe-wny>