Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Feb 2016 17:26:55 +0100
From:      Matthias Apitz <guru@unixarea.de>
To:        office@FreeBSD.org
Subject:   Re: [Bug 205922] editors/libreoffice: Does not end on Ctrl-Q or file menu (version 5.0.4)
Message-ID:  <20160206162655.GA2328@c720-r292778-amd64>
In-Reply-To: <bug-205922-25061-GlYQQMY4Dg@https.bugs.freebsd.org/bugzilla/>
References:  <bug-205922-25061@https.bugs.freebsd.org/bugzilla/> <bug-205922-25061-GlYQQMY4Dg@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
El día Friday, February 05, 2016 a las 09:00:29PM +0000, bugzilla-noreply@freebsd.org escribió:

> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205922
> 
> --- Comment #3 from Matthias Apitz <guru@unixarea.de> ---
> the problem is caused by closing the socket file descriptors in one thread,
> while another thread is still in accept(2) on the same socket and this is not
> canceled in the OS; the same is true for pipes; I'm attaching patches for this
> to be placed in editors/libreoffice/files;

Two remarks on this.

The bugfix is based on hints from Damjan Jovanovic who fixed the same in
Apache Open Office some time ago.


Later, after applying my patches, I got some hint about a change in the LO
sources in October 2015:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=309aa845a8e413519d634680aff112a3567e2e61

To be honestly, I'm sad now. 

This is nearly the same fix I have done now in the FreeBSD port of LO
which is based on v5.0.4.2; The only diff is, that I have had to fix
also the file sal/osl/unx/pipe.cxx; I’m wondering why the actual
maintainer of the port in FreeBSD was not aware of this bug and fix(!) from
October 2015, esp. due to the nature of the bug which makes the usage of
LO from a desktop icon nearly impossible ... and I’m wondering about the zero
echo after posting this bug in the FBSD’ lists and in bugzilla, maybe nobody
uses LO 5.0.4 in FreeBSD at all.

Anyway, lesson learned: check the original source tree before digging
into something.

And thanks again to Damjan for the helping hand. 

	matthias
-- 
Matthias Apitz, ✉ guru@unixarea.de, ⌂ http://www.unixarea.de/  ☎ +49-176-38902045
UNIX since V7 on PDP-11 | UNIX on mainframe since ESER 1055 (IBM /370)
UNIX on x86 since SVR4.2 UnixWare 2.1.2 | FreeBSD since 2.2.5



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160206162655.GA2328>