Date: Sun, 03 Apr 2011 20:43:45 +0300 From: Mikolaj Golub <trociny@freebsd.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: Mikolaj Golub <trociny@freebsd.org>, Victor Balada Diaz <victor@bsdes.net>, stable@freebsd.org, Kostik Belousov <kib@FreeBSD.org> Subject: Re: geli(4) memory leak Message-ID: <86zko7nsby.fsf@kopusha.home.net> In-Reply-To: <20110402101750.GD1849@garage.freebsd.pl> (Pawel Jakub Dawidek's message of "Sat, 2 Apr 2011 12:17:50 %2B0200") References: <20110326003348.GQ36706@equilibrium.bsdes.net> <20110401174354.GE1289@equilibrium.bsdes.net> <86pqp53cqe.fsf@kopusha.home.net> <20110402101750.GD1849@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2 Apr 2011 12:17:50 +0200 Pawel Jakub Dawidek wrote: PJD> On Sat, Apr 02, 2011 at 12:04:09AM +0300, Mikolaj Golub wrote: >> For me your patch look correct. But the same issue is for read :-). Also, to >> avoid the leak I think we can just do g_destroy_bio() before "all sectors" >> check. See the attached patch (had some testing). PJD> The patch looks good. Please commit. Commited, thanks. -- Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86zko7nsby.fsf>