Date: Sun, 17 Aug 2014 17:39:23 +0200 From: olli hauer <ohauer@gmx.de> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org, Adam Weinberger <adamw@FreeBSD.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r365003 - head/devel/elfsh/files Message-ID: <53F0CCAB.1030706@gmx.de> In-Reply-To: <20140817152003.GA83527@FreeBSD.org> References: <201408151704.s7FH4f4W071527@svn.freebsd.org> <20140816164551.GA86642@FreeBSD.org> <53EF9469.3070704@gmx.de> <20140817091822.GA51054@FreeBSD.org> <7012BDCA-0949-4A7F-A017-D8F76476F8B9@adamw.org> <53F0C0BC.2000902@marino.st> <53F0C6AB.8070309@gmx.de> <20140817152003.GA83527@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-08-17 17:20, Alexey Dokuchaev wrote: > On Sun, Aug 17, 2014 at 05:13:47PM +0200, olli hauer wrote: >> On 2014-08-17 16:48, John Marino wrote: >>> patch-mod_foo__main.c is too simple. >>> Try: >>> patch-alpha__bravo__charlie__delta-echo__foxtrot__golf__hotel__india_juliet.cpp >>> >>> then 20 more of those in the same directory. Very ugly. >>> >>> eye of the beholder I guess. >> >> No, your example looks pretty to me ;) >> >> At last if I compare your example with '+' or '-' that is also not clash free. >> >> patch-alpha__bravo__charlie__delta-echo__foxtrot__golf__hotel__india_juliet.cpp >> patch-alpha+bravo+charlie+delta-echo+foxtrot+golf+hotel+india_juliet.cpp >> patch-alpha-bravo-charlie-delta-echo-foxtrot-golf-hotel-india_juliet.cpp >> >> E.g. in devel/psptoolchain-newlib it is not clear without reading the full >> patch filename in which path the patch applies. > > Olli, there always be edge cases that could benefit from a particular path > separator being used instead of the default one (whatever it is). No one's > preventing you from picking the one that suits better. The poing is that > most of the times there is no need to uglify patches with __, but currently > it's being used by makepatch. We don't like it, and more than just talking > about it, there is a working code to play with and see if it makes sense. > > ./danfe > If we go the new patch route then the patch separator should be specified and read from the the $port/Makefile. E.g. Say you prefer as separator a singel '+' to shape patches, after some time another porter or a simple user trying to create a patch using '_' as default then it will end in a mess. Until now it was always clear with makepatch, the main issue was even devs answering often it is documented have overseen the passage ... I've looked over the patch in Phabricator but haven't seen any technical improvement except it renders for some devs a more pretty patch name.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53F0CCAB.1030706>