Date: Fri, 5 Feb 2016 20:52:50 +0100 From: John Marino <freebsd.contact@marino.st> To: Bryan Drewery <bdrewery@FreeBSD.org>, John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r408262 - head/editors/uemacs Message-ID: <56B4FD92.9080504@marino.st> In-Reply-To: <56B4FC78.6050005@FreeBSD.org> References: <201602051859.u15IxnEx021230@repo.freebsd.org> <56B4FC78.6050005@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/5/2016 8:48 PM, Bryan Drewery wrote: > On 2/5/2016 10:59 AM, John Marino wrote: >> Author: marino >> Date: Fri Feb 5 18:59:49 2016 >> New Revision: 408262 >> URL: https://svnweb.freebsd.org/changeset/ports/408262 >> >> Log: >> editors/uemacs: document ncurses rqmt (USES+=ncurses), respect LDFLAGS >> >> Also link with ncurses, not termcap >> >> approved by: infrastructure blanket >> >> Modified: >> head/editors/uemacs/Makefile >> >> Modified: head/editors/uemacs/Makefile >> ============================================================================== >> --- head/editors/uemacs/Makefile Fri Feb 5 18:57:54 2016 (r408261) >> +++ head/editors/uemacs/Makefile Fri Feb 5 18:59:49 2016 (r408262) >> @@ -13,10 +13,12 @@ COMMENT= Full screen editor >> NO_CDROM= Resale allowed for media cost only >> >> NO_WRKSUBDIR= yes >> -USES= dos2unix zip >> +USES= dos2unix ncurses zip >> EXTRACT_BEFORE_ARGS= -Lq >> >> post-patch: >> @${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/src/*.c >> + @${REINPLACE_CMD} -e 's|-ltermcap|${LDFLAGS} -lncurses|g' \ >> + ${WRKSRC}/freebsd/makefile >> >> .include <bsd.port.mk> >> > > lrwxr-xr-x 1 root wheel 13 Mar 27 2015 /usr/lib/libtermcap.so@ -> > libncurses.so > > libtermcap is symlinked to libncurses. Why is it worth maintaining extra > code to link to ncurses directly? > Libtermcap does not exist in ports, it's not in devel/ncurses. If one wants doesn't want to use base, the port can't be built. The obvious solution is make everythink link with libncurses so both base and ports options are supported.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56B4FD92.9080504>