Date: Wed, 19 Sep 2018 10:13:22 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: java@FreeBSD.org Subject: Fwd: Request for Approval: Backport of JDK-8205965: SIGSEGV on write to NativeCallStack::EMPTY_STACK Message-ID: <19EDB12C-A2AE-4B49-BEE4-5215138985A3@FreeBSD.org> References: <58ed90b3-ee3d-9c8b-70a3-b7f3a7398040@loongson.cn>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_F87BCF78-C011-494D-B227-577DD8A04256 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 FYI. I'm testing this patch (at = http://cr.openjdk.java.net/~zgu/8205965_8u/webrev.00/ ) locally, which = reverts the fix we committed for = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225054 in = https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D459368, and = solves the issue in another way. -Dimitry > Begin forwarded message: >=20 > From: Leslie Zhai <zhaixiang@loongson.cn> > Subject: Re: Request for Approval: Backport of JDK-8205965: SIGSEGV on = write to NativeCallStack::EMPTY_STACK > Date: 19 September 2018 at 03:22:48 CEST > To: Zhengyu Gu <zgu@redhat.com>, Se=C3=A1n Coffey = <sean.coffey@oracle.com> > Cc: jdk8u-dev <jdk8u-dev@openjdk.java.net>, Dimitry Andric = <dimitry@andric.com> >=20 > Hi Zhengyu, >=20 > Thanks for your sponsor! >=20 > I will run jtreg towards: >=20 > * jdk8u-dev, base on 8722:16b9bbfaa450, applied with the patch, = compiled with clang-6 and clang-8-dev >=20 > * jdk8u-dev, base on 8722:16b9bbfaa450, compiled with gcc-6.4.3 and = gcc-9-dev >=20 > Then run jtdiff on Linux X86. >=20 > Hi Dimitry, >=20 > Please verify the patch on FreeBSD compiled with clang-6, thanks a = lot! >=20 > Thanks, >=20 > Leslie Zhai >=20 >=20 > =E5=9C=A8 2018=E5=B9=B409=E6=9C=8819=E6=97=A5 07:06, Zhengyu Gu = =E5=86=99=E9=81=93: >> Hi Leslie, >>=20 >> The backport is approved. >>=20 >> Please send me *committed* patch [1] after proper tests, I will = sponsor it for you. >>=20 >> Thanks, >>=20 >> -Zhengyu >>=20 >> [1] http://openjdk.java.net/sponsor/ Section 3 >>=20 >> You should use commit message from original patch and add yourself as = contributor, ex. >>=20 >> 8205965: SIGSEGV on write to NativeCallStack::EMPTY_STACK >> Summary: Made EMPTY_STACK non-const, so it will not be placed in = read-only BSS section. >> Reviewed-by: stuefe, martin >> Contributed-by: zhaixiang@loongson.cn >>=20 >>=20 >>=20 >> On 09/18/2018 06:28 PM, Se=C3=A1n Coffey wrote: >>> Approved for jdk8u-dev. >>>=20 >>> regards, >>> Sean. >>>=20 >>>=20 >>> On 18/09/2018 07:48, Leslie Zhai wrote: >>>> Hi Zhengyu, >>>>=20 >>>> I would like to backport the fix for: >>>>=20 >>>> https://bugs.openjdk.java.net/browse/JDK-8205965 >>>>=20 >>>> To OpenJDK 8 updates dev: >>>>=20 >>>> http://hg.openjdk.java.net/jdk8u/jdk8u-dev >>>>=20 >>>> The fix is mostly the same as the version that was committed in 12, = here is the patch: >>>>=20 >>>> http://cr.openjdk.java.net/~zgu/8205965_8u/webrev.00/ >>>>=20 >>>> The patch was reviewed, thanks for your review! Here is the = relevant thread: >>>>=20 >>>> = http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-September/007860.htm= l >>>>=20 >>>> A patch by Loongson! Please sponsor it, thanks a lot! >>>>=20 >>>=20 >=20 >=20 --Apple-Mail=_F87BCF78-C011-494D-B227-577DD8A04256 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCW6IFIgAKCRCwXqMKLiCW o2tKAKDjLRUVmbBQM7J2T6kSgkyLYk/6owCfUAEejztheG7TIbomV4quMT+R2tk= =jVbt -----END PGP SIGNATURE----- --Apple-Mail=_F87BCF78-C011-494D-B227-577DD8A04256--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19EDB12C-A2AE-4B49-BEE4-5215138985A3>